Bug 420219 - Smart patch tool change area outside an selection
Summary: Smart patch tool change area outside an selection
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Smart Patch (show other bugs)
Version: 4.2.9-beta1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-17 20:00 UTC by Alexey
Modified: 2020-06-13 10:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2020-04-17 20:00:47 UTC
1. Make selection
2. Use smart patch tool ::)
3. ...

It's works for whole image


But it should do only for part of image inside selection


Linux Mint 19.2 Cinnamon 
appimage
Comment 1 Ahab Greybeard 2020-04-23 14:03:47 UTC
I can confirm this happens for the 4.2.9 appimage, so setting to Confirmed.

However, because of how the tool works, is it not intended to be used with selections and so ignores them?
(If so, this is not stated in the manual.)
Comment 2 Dmitry Kazakov 2020-06-13 10:08:31 UTC
Git commit db0093605280edcf816658c8cf66984f808db161 by Dmitry Kazakov.
Committed on 13/06/2020 at 10:08.
Pushed by dkazakov into branch 'krita/4.3'.

Make Smart Patch Tool consider active selection

M  +13   -4    plugins/tools/tool_smart_patch/kis_inpaint.cpp
M  +13   -6    plugins/tools/tool_smart_patch/kis_tool_smart_patch.cpp

https://invent.kde.org/graphics/krita/commit/db0093605280edcf816658c8cf66984f808db161
Comment 3 Dmitry Kazakov 2020-06-13 10:08:42 UTC
Git commit 90b5b66bf19986c0627c84a739898b6aae936cb1 by Dmitry Kazakov.
Committed on 13/06/2020 at 10:08.
Pushed by dkazakov into branch 'master'.

Make Smart Patch Tool consider active selection

M  +13   -4    plugins/tools/tool_smart_patch/kis_inpaint.cpp
M  +13   -6    plugins/tools/tool_smart_patch/kis_tool_smart_patch.cpp

https://invent.kde.org/graphics/krita/commit/90b5b66bf19986c0627c84a739898b6aae936cb1