Bug 420197 - Media Player applet without icon in system tray settings if something with cover is playing
Summary: Media Player applet without icon in system tray settings if something with co...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-17 12:25 UTC by Patrick Silva
Modified: 2020-05-24 14:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
missing icon (88.02 KB, image/png)
2020-04-17 12:25 UTC, Patrick Silva
Details
icon is present when nothing is playing (97.90 KB, image/png)
2020-04-17 12:25 UTC, Patrick Silva
Details
music without cover, icon present in systray settings (237.28 KB, image/png)
2020-05-15 23:04 UTC, Patrick Silva
Details
music with cover, misisng icon in systray settings (322.76 KB, image/png)
2020-05-15 23:05 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-04-17 12:25:03 UTC
Created attachment 127611 [details]
missing icon

STEPS TO REPRODUCE
1. play audio/video with a player compatible with Media Player applet
2. open system tray settings during playback
3. 

OBSERVED RESULT
icon of Media Player applet is missing in system tray settings.
Such icon is present when nothing is playing.
See the attached screnshots please.

EXPECTED RESULT
icon of Media Player applet should always be present in system tray settings

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-04-17 12:25:51 UTC
Created attachment 127612 [details]
icon is present when nothing is playing
Comment 2 Kai Uwe Broulik 2020-04-17 15:30:01 UTC
Git commit 38c269dc486dac19d883cc2a22d3e4999284cae4 by Kai Uwe Broulik.
Committed on 17/04/2020 at 15:29.
Pushed by broulik into branch 'master'.

[Media Controller] Don't set album art on tooltip anymore

We don't show icons on tooltips anymore.
And the System Tray config doesn't show images.
FIXED-IN: 5.19.0

Differential Revision: https://phabricator.kde.org/D28917

M  +1    -1    applets/mediacontroller/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/38c269dc486dac19d883cc2a22d3e4999284cae4
Comment 3 Patrick Silva 2020-05-15 12:53:14 UTC
This bug is reproducible again.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.90
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0 rc2
Comment 4 Patrick Silva 2020-05-15 23:04:23 UTC
Created attachment 128498 [details]
music without cover, icon present in systray settings

I have just noticed that this issue only occurs if the music playing has a cover.
If I play a music without cover or a video with VLC player, the icon of media player applet is present in system tray settings. See the attached screenshots please.
Comment 5 Patrick Silva 2020-05-15 23:05:17 UTC
Created attachment 128499 [details]
music with cover, misisng icon in systray settings
Comment 6 Konrad Materka 2020-05-24 14:54:01 UTC
Git commit 6f826a1b5898f334ef3c79c9f6659513ae0447f8 by Konrad Materka.
Committed on 24/05/2020 at 14:40.
Pushed by broulik into branch 'Plasma/5.19'.

[applets/mediacontroller] Don't use Album Art for icon

Summary:
Icon of Media Player applet is missing in the System Tray settings when
the media playing has a cover. Such icon is present when nothing is playing.
Fix by not using album art in any case - icon is not longer used in
tooltip, can be static.

FIXED-IN: 5.19.0

Test plan:
1. play audio/video with a player compatible with Media Player applet
2. open system tray settings during playback
3. Icon of Media Player applet is always present in system tray
settings, regardless of state.

M  +0    -2    applets/mediacontroller/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/6f826a1b5898f334ef3c79c9f6659513ae0447f8