Bug 420196 - A KCM is re-loaded when its entry in a subcategory list/column is clicked
Summary: A KCM is re-loaded when its entry in a subcategory list/column is clicked
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 419336 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-17 12:01 UTC by Patrick Silva
Modified: 2020-09-28 19:34 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/systemsettings/commit/d923aeec835d6a9c195846a00e16566de0af901c
Version Fixed In: 5.20
Sentry Crash Report:

Attachments
screen recording (2.30 MB, video/webm)
2020-04-17 12:01 UTC, Patrick Silva 		Details
re-loaded KCMs (1.36 MB, video/webm)
2020-04-24 11:59 UTC, Patrick Silva 		Details
re-loaded KCMs 2 (2.47 MB, video/webm)
2020-04-24 12:14 UTC, Patrick Silva 		Details
re-loaded KCMs 3 (1.68 MB, video/webm)
2020-04-24 12:15 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-04-17 12:01:04 UTC 
Created attachment 127610 [details]
screen recording

STEPS TO REPRODUCE
1. open system settings in side bar view
2. open any of the following KCMs:
   fonts > fonts
   workspace behavior > general behavior
   search > file search
   applications > launch feedback
   display and monitor > night color
3. click on the entry of the current KCM listed in subcategories column

OBSERVED RESULT
KCM header blinks. Watch the attached screen recording please.

EXPECTED RESULT
KCM header should not blink

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1
Comment 1 Nate Graham 2020-04-17 17:25:11 UTC 
It's not just that; the whole KCM is actually reloaded.
Comment 2 Patrick Silva 2020-04-24 11:59:00 UTC 
Created attachment 127825 [details]
re-loaded KCMs

(In reply to Nate Graham from comment #1)
> It's not just that; the whole KCM is actually reloaded.

Yes. As we can observe watching my additional screen recordings, it's much more noticeable with other KCMs.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1
Comment 3 Patrick Silva 2020-04-24 12:14:23 UTC 
Created attachment 127831 [details]
re-loaded KCMs 2
Comment 4 Patrick Silva 2020-04-24 12:15:14 UTC 
Created attachment 127832 [details]
re-loaded KCMs 3
Comment 5 David Edmundson 2020-09-27 22:32:20 UTC 
*** Bug 419336 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2020-09-28 10:59:47 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/22
Comment 7 Nate Graham 2020-09-28 19:32:10 UTC 
Git commit 9daf327a6c68d9101dbb7fff92e406bd677215ef by Nate Graham, on behalf of David Edmundson.
Committed on 28/09/2020 at 19:31.
Pushed by ngraham into branch 'master'.

[Sidebar] Avoid reloading already loaded module

M  +10   -5    sidebar/SidebarMode.cpp

https://invent.kde.org/plasma/systemsettings/commit/9daf327a6c68d9101dbb7fff92e406bd677215ef
Comment 8 Nate Graham 2020-09-28 19:32:40 UTC 
Git commit d923aeec835d6a9c195846a00e16566de0af901c by Nate Graham, on behalf of David Edmundson.
Committed on 28/09/2020 at 19:32.
Pushed by ngraham into branch 'Plasma/5.20'.

[Sidebar] Avoid reloading already loaded module


(cherry picked from commit 9daf327a6c68d9101dbb7fff92e406bd677215ef)

M  +10   -5    sidebar/SidebarMode.cpp

https://invent.kde.org/plasma/systemsettings/commit/d923aeec835d6a9c195846a00e16566de0af901c