Bug 420112 - A title of the keyboard layout preview window seems to be hardcoded
Summary: A title of the keyboard layout preview window seems to be hardcoded
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keyboard_layout (show other bugs)
Version: 5.18.3
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-15 11:59 UTC by msmetko
Modified: 2020-06-03 08:47 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/10d94991dd4679fbc0fb40ef7b4892673150152a
Version Fixed In: 5.20
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description msmetko 2020-04-15 11:59:52 UTC 
SUMMARY
A title of the keyboard layout preview window seems to be hardcoded

STEPS TO REPRODUCE
1. Enter Keyboard settings
2. Go on layout tab
3. Click add button
4. Choose whatever language and whatever layout
5. Press preview

OBSERVED RESULT
The title of the windows says 'tastenbrett'

EXPECTED RESULT
I think the title should be localized

SOFTWARE/OS VERSIONS
Windows: N/A
macOS: N/A
Linux/KDE Plasma: Kubuntu 19.10
(available in About System)
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.67.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
Comment 1 Christoph Feck 2020-05-06 22:51:29 UTC 
"tastenbrett" is the executable name of the keyboard layout viewer, and Qt uses this as the application name which is then shown in the window title.

The "tastenbrett" application should indeed set a window title with i18n.
Comment 2 Christoph Feck 2020-05-06 22:55:38 UTC 
The canonical way to do this is using KAboutData associated to the application.
Comment 3 msmetko 2020-05-07 05:33:41 UTC 
(In reply to Christoph Feck from comment #2)
> The canonical way to do this is using KAboutData associated to the
> application.

If it's an easy fix, I'd be happy to volunteer :)
Comment 4 Christoph Feck 2020-05-07 12:54:58 UTC 
I was indeed tempted to mark it as a junior job, because examples of KAboutData use are in literally every KDE application's main.cpp.

The problem is that this data usually includes license, authors, contributors, their public mail addresses, etc., and it's best if the author/maintainer of the application collects this information.

Thanks for your offer, though!
Comment 6 Harald Sitter 2020-06-03 08:47:29 UTC 
Git commit 10d94991dd4679fbc0fb40ef7b4892673150152a by Harald Sitter.
Committed on 03/06/2020 at 08:47.
Pushed by sitter into branch 'master'.

set kaboutdata for keyboard preview to get a window title set

without this the window title defaults to bin name which is worthless.

also updated messages.sh to find files recursively + pick up qml (not
currently used)

the domain is inherited from parent cmakelists of the kcm

FIXED-IN: 5.20

M  +1    -1    kcms/keyboard/Messages.sh
M  +2    -0    kcms/keyboard/tastenbrett/CMakeLists.txt
M  +13   -2    kcms/keyboard/tastenbrett/main.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/10d94991dd4679fbc0fb40ef7b4892673150152a