Bug 420089 - .kml files cause thumbnail.so to pop up error message windows
Summary: .kml files cause thumbnail.so to pop up error message windows
Status: REPORTED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-14 17:55 UTC by Laura David Hurka
Modified: 2020-11-03 11:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Example file with some KML code, which causes thumbnail.so to pop up error message windows. (1.52 KB, application/vnd.google-earth.kml+xml)
2020-04-14 17:55 UTC, Laura David Hurka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laura David Hurka 2020-04-14 17:55:36 UTC
Created attachment 127547 [details]
Example file with some KML code, which causes thumbnail.so to pop up error message windows.

SUMMARY
After streamplot-config+xml .spx, I created the next killer file type. :D Keymap logic (.kml) files cause thumbnail.so to pop up error message windows which say "Invalid Document". This can be problematic, because for every file one such window is created, which potentially steals focus.

.kml seams to be associated to “KML geographic data”

STEPS TO REPRODUCE
1. Navigate Dolphin or another KIO application to the attached test.kml

OBSERVED RESULT
Error message window pops up: "Invalid Document"

EXPECTED RESULT
thumbnail.so realizes that it doesn’t understand Keymap Logic Language, and pops up no window.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.18
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.1
Kernel Version: 5.3.0-46-generic
Comment 1 Kai Uwe Broulik 2020-04-14 18:00:56 UTC
Re-assigning to Marble where the KML thumbnailer comes from
Comment 2 Stefan Brüns 2020-11-03 11:08:16 UTC
Git commit 5e2c369a754a7457f2a746edd057ccc475c962af by Stefan Brüns.
Committed on 02/11/2020 at 17:19.
Pushed by rahn into branch 'master'.

Dont open a MessageBox when a file fails to load from the library

As the filemanager is also used from non-interactive contexts, a message
box is a no-go.

Interactive applications can connect to the fileError signal. This is
done for both marble-qt and marble-kde.
Related: bug 416925

M  +8    -0    src/apps/marble-kde/marble_part.cpp
M  +8    -0    src/apps/marble-qt/QtMainWindow.cpp
M  +0    -6    src/lib/marble/FileManager.cpp

https://invent.kde.org/education/marble/commit/5e2c369a754a7457f2a746edd057ccc475c962af