Created attachment 127344 [details] screen recording SUMMARY Every time I open "Samba status" window, "Mounted under" column label is cut off. Watch the attached screen recording please. EXPECTED RESULT all columns labels in "Samba status" window should always be entirely readable. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.18.80 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.1
Git commit f2c5e10d4af386be00719f7c75de992a80e18948 by Harald Sitter. Committed on 14/04/2020 at 11:24. Pushed by sitter into branch 'Plasma/5.18'. adjust smb kcm size to be sufficient vis a vis headers Summary: we use Stretch to get a somewhat uniform appearance between the two views but Stretch is bit meh when it comes to actual sizing as it acts kind of like QSizePolicy::Preferred in that it allows shrinking columns so small that even the header gets cut off. this of course looks silly, so we now set the largest required width as minimal section width. this prevents the user from cutting off headers by resizing the window. secondly, and entirely related to that, because KCMs are embedded into a scrollview their sizehint kinda doesn't make any difference for the window size which then combined with the aforementioned stretch problem can lead to cut off headers by default as the window size is too small making the stretch cut into header text. to ensure the default size is reasonable let the view adjust to content on first show, effectively making the window as large as needed regardless of implicit hints. FIXED-IN: 5.18.5 Test Plan: - empty dialog - dialog with only shares - dialog with shares and mounts Reviewers: ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28678 M +19 -0 Modules/samba/main.cpp https://commits.kde.org/kinfocenter/f2c5e10d4af386be00719f7c75de992a80e18948