Bug 419736 - Script actions doesn't work when certain layer types selected
Summary: Script actions doesn't work when certain layer types selected
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Scripting (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-06 17:10 UTC by radian
Modified: 2020-04-07 13:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description radian 2020-04-06 17:10:08 UTC
SUMMARY
I have a plugin with bunch of functions assigned to hotkeys but I can't use them if group layer selected. I need to click on some normal layer, use the hotkey and then switch back. 
Same thing happens with vector and clone layers but group layers is much more annoying.


STEPS TO REPRODUCE
1. assign some brush for hotkey (Ten brushes plugin is probably simplest way to reproduce)
2. select group layer
3. use the hotkey

OBSERVED RESULT
Action didn't do anything, brush stays the same.

EXPECTED RESULT
Brush changed to assigned one/

SOFTWARE/OS VERSIONS
Windows 10
Comment 1 Halla Rempt 2020-04-07 12:32:50 UTC
Git commit 7c9897fb410af469dc920e95529d2110057aeebd by Boudewijn Rempt.
Committed on 07/04/2020 at 12:31.
Pushed by rempt into branch 'master'.

Remove the activation flags for the ten brushes script

Whether an action can be toggled depends on the activation flags
in the .action files.

It's fine to be able to activate a new preset if the current layer
isn't a paint layer.

M  +10   -10   plugins/python/tenbrushes/tenbrushes.action

https://invent.kde.org/kde/krita/commit/7c9897fb410af469dc920e95529d2110057aeebd
Comment 2 Halla Rempt 2020-04-07 13:21:01 UTC
Git commit ae89b1899c21c00e0b24c04257d59e73b52bfdab by Boudewijn Rempt.
Committed on 07/04/2020 at 13:20.
Pushed by rempt into branch 'krita/4.3'.

Remove the activation flags for the ten brushes script

Whether an action can be toggled depends on the activation flags
in the .action files.

It's fine to be able to activate a new preset if the current layer
isn't a paint layer.
(cherry picked from commit 7c9897fb410af469dc920e95529d2110057aeebd)

M  +10   -10   plugins/python/tenbrushes/tenbrushes.action

https://invent.kde.org/kde/krita/commit/ae89b1899c21c00e0b24c04257d59e73b52bfdab