Bug 419716 - always search on keyboard input
Summary: always search on keyboard input
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Emoji Selector (show other bugs)
Version: 5.18.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-06 12:48 UTC by Harald Sitter
Modified: 2020-05-23 00:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2020-04-06 12:48:12 UTC
SUMMARY
when typing on any page the picker should do a search (ideally filter the page one is on, but I expect that's a headache)

STEPS TO REPRODUCE
1. open picker
2. type cat

OBSERVED RESULT
nothing happens

EXPECTED RESULT
cat emojis show up

more generally: no matter the page, on keyboard input that isn't navigation -> jump to search -> search for keyboard input

the motivation here is that if I know what I am looking for I'd want to get to it without having to use the mouse seeing as I needed the keyboard already to trigger the picker anyway and likely in a way that had me remove my hand from the mouse.
Comment 1 Nate Graham 2020-04-15 03:00:11 UTC
Yeah. See https://phabricator.kde.org/D28539.
Comment 2 Aleix Pol 2020-05-23 00:26:40 UTC
Git commit 01352d727e058094859e4426602f4b37350089f1 by Aleix Pol, on behalf of Nate Graham.
Committed on 23/05/2020 at 00:24.
Pushed by apol into branch 'Plasma/5.19'.

[Emoji panel] search when the user begins typing

Right now you need to hit Ctrl + F to start searching. This patch
additionally makes the
search start as soon as you start typing.

It's a bit slow though, not sure why?
FIXED-IN: 5.19.0

M  +8    -0    applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
M  +4    -0    applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

https://invent.kde.org/plasma/plasma-desktop/commit/01352d727e058094859e4426602f4b37350089f1
Comment 3 Aleix Pol 2020-05-23 00:27:04 UTC
Git commit 3e6b64e6daf64a82c2f95036e9c031d0246490ec by Aleix Pol, on behalf of Nate Graham.
Committed on 23/05/2020 at 00:26.
Pushed by apol into branch 'master'.

[Emoji panel] search when the user begins typing

Right now you need to hit Ctrl + F to start searching. This patch
additionally makes the
search start as soon as you start typing.

It's a bit slow though, not sure why?
FIXED-IN: 5.19.0

M  +8    -0    applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
M  +4    -0    applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

https://invent.kde.org/plasma/plasma-desktop/commit/3e6b64e6daf64a82c2f95036e9c031d0246490ec