Bug 419529 - Text Tool broken
Summary: Text Tool broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: 4.2.8
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords: regression, release_blocker, triaged
Depends on:
Blocks:
 
Reported: 2020-04-02 08:50 UTC by Bollebib
Modified: 2020-05-12 19:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2020-04-02 08:50:49 UTC
Creating or trying to edit an existing text opens the Text Popup in some unknown location. 
You cant see the text  popup, and it steals away the focus of the screen meaning that the current krita session is locked. Pressing escape also doesnt close the popup window



This didnt happen in the previous krita  version

I marked it as a dangerous vug cause if you encounter it while woking you are forced to force quit krita and potentially lose progress.





Possible workarounds for the future
1) allow escape to close the popup wherever it is
2) create an actual window that you can find in the file explorer that you can close

Tegardless of this issue i feel the above 2 options should be possible
Comment 1 Halla Rempt 2020-04-03 14:01:10 UTC
Um, this cannot be new... The last time this code was touched was in May. If it is broken, must already been broken in 4.2.8, I think. I am afraid I cannot reproduce it on my windows laptop, though I remember once having seen something like this happen.
Comment 2 Ahab Greybeard 2020-04-03 14:31:59 UTC
I raised a bug report for something like this in May last year:
https://bugs.kde.org/show_bug.cgi?id=407878

The thing is that not everybody can reproduce it.

Early this year, I saw it 'fixed' in a nightly build and then come back again a few days later in a newer nightly build. (I use Linux appimages and don't pay much attention to Windows.)

As far as I can see it's to do with the z-order of the text window with respect to the other windows. I have floating dockers on a second monitor and it can hide behind them.

I can fix it for a session by selecting the Default workspace, then I can switch to my two screen workspace and after that the text box is on top of my floating dockers.

There is another way that involves docking then undocking a floating docker that seems to fix it for a session.

I keep meaning to investigate it with proper note taking and reopen my old bug report but I never get around to it.

Are you using a multi-monitor arrangement?
Do you have floating dockers?
Comment 3 Bollebib 2020-04-13 19:16:40 UTC
yes i use multiple monitors  ,so maybe it appears somewhere outside of all my desktops.


one solution would be to have some sort of reset  so the popup gets confined to the krita window


another would be to at least allow for ESCAPE to work so the screen doesnt lock up indefinitly


I dont use floating dockers
Comment 4 vanyossi 2020-04-24 01:06:39 UTC
This just happened to me under multiple monitors. The text editor is opened in the second monitor at max width and height. On macos, my test machine, the text editor does not dissapear, however after the first usage any call after that shows the editor in the last position before closing.

The first odd position and size can be recreated by renaming kritarc and opening text tool on a multiple monitor setup.

I cannot test multiple monitor on Linux or Windows. The monitor/cable combination does not work to get a second display.
Comment 5 wolthera 2020-04-24 11:35:09 UTC
ivan can reproduce it, so let's set to confirmed.
Comment 6 Halla Rempt 2020-05-04 08:06:45 UTC
Ivan, I think that this fix of yours:

commit 8c2122b09435a419e10145190f1209a35403fae8
Author: Ivan Yossi <ghevan@gmail.com>, Tue May 14 11:35:37 2019 -0500 (12 months ago)
Committer: Ivan Yossi <ghevan@gmail.com>, Wed May 15 00:23:58 2019 -0500 (12 months ago)
Follows: v4.2.0-beta
Precedes: v42.0-beta2
Branches: <Expand>

Improve modal SvgTextToolEditor


Caused this issue.
Comment 7 vanyossi 2020-05-11 07:08:26 UTC
Git commit 3d625ec0fbe990eb3416fe46d0d684c49d6c80b5 by Ivan Yossi.
Committed on 11/05/2020 at 07:06.
Pushed by ivany into branch 'master'.

fix position of text tool on new sessions

VirtualGeometry reports the monitor resolution of the screen,
however on HiDPi monitors coordinates and geometry from
virtualGeometry does not match.

Use regular screen geometry yo avoid creating the window with
negative coordinates on x or y.

M  +2    -2    plugins/tools/svgtexttool/SvgTextEditor.cpp

https://invent.kde.org/kde/krita/commit/3d625ec0fbe990eb3416fe46d0d684c49d6c80b5
Comment 8 vanyossi 2020-05-12 19:13:09 UTC
Git commit d24685ac164972c5606273c7c9efd07e39531d40 by Ivan Yossi.
Committed on 12/05/2020 at 19:12.
Pushed by ivany into branch 'krita/4.3'.

fix position of text tool on new sessions

VirtualGeometry reports the monitor resolution of the screen,
however on HiDPi monitors coordinates and geometry from
virtualGeometry does not match.

Use regular screen geometry yo avoid creating the window with
negative coordinates on x or y.

M  +2    -2    plugins/tools/svgtexttool/SvgTextEditor.cpp

https://invent.kde.org/kde/krita/commit/d24685ac164972c5606273c7c9efd07e39531d40