Bug 419524 - lyrics exist in db and are not displayed
Summary: lyrics exist in db and are not displayed
Status: REPORTED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: kf5
Platform: openSUSE Linux
: NOR normal
Target Milestone: kf5
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-02 07:36 UTC by Philippe Conde
Modified: 2020-04-25 20:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
tracks details differences from playlist and from media source (49.10 KB, image/png)
2020-04-18 14:05 UTC, Philippe Conde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Conde 2020-04-02 07:36:32 UTC
I have amarok using a mariadb database (mysql) as backend.

When I move  tracks to the playlist and start playing the lyrics are not displayed.
Stopping amarok, quit amarok and reload amarok solve most of the time the problem for the current playlist tracks. Adding other tracks give the same problem for the added tracks. 


STEPS TO REPRODUCE
1. Have tracks with lyrics saved in table lyrics
2. Set some of these tracks in the playlist 
3. Start playing. the lyrics in the context frame are not displayed  ==> "No lyrics found"
4. Stop playing
5. Quit amarok (file ==> quit)
6. Reload amarok ==> one notification is shown "Synchronisation de Amarok terminée. Une piste a été mise à jour".ENG : Amarok synchronization finished. One tracks updated.

7. Start playing ==> the lyrics are displayed in the context frame
 
OBSERVED RESULT
The lyrics are not retrieved from the table lyrics. Need to quit and restart amarok 

EXPECTED RESULT
The lyrics should be retrieved without need to restart amarok.I think that a synchronisation must occur for each track added in the playlist

SOFTWARE/OS VERSIONS
Opensuse tumbleweed 64 bits

Linux/KDE Plasma: 5.18.3
(available in About System)
KDE Plasma Version:5.18.3 
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION

amarok : 2.9.70git.20200225T224218~2084224e4c-1.1 (current tumbleweed rpm version)
Comment 1 Philippe Conde 2020-04-18 14:05:40 UTC
Created attachment 127643 [details]
tracks details differences from playlist and from media source

One observation:
I have a track in the playlist. I restart amarok and using the track details (right button) on the playlist I can see the lyrics in tab lyrics
If I select the same track from the media source and go to the track details the lyrics tab is empty.Same for all other tracks in the media source (local collection)

See image linked
Comment 2 Pedro de Carvalho Gomes 2020-04-20 18:37:49 UTC
I ran the same version at Opensuse Tumbleweed, but could not detect the error. Please run in debug mode (amarok -d) and attach the log here. Please open few tracks to help identifying where the problem might be

(In reply to Philippe Conde from comment #1)
> Created attachment 127643 [details]
> tracks details differences from playlist and from media source
> 
> One observation:
> I have a track in the playlist. I restart amarok and using the track details
> (right button) on the playlist I can see the lyrics in tab lyrics
> If I select the same track from the media source and go to the track details
> the lyrics tab is empty.Same for all other tracks in the media source (local
> collection)
> 
> See image linked
Comment 3 Philippe Conde 2020-04-21 10:09:57 UTC
Hello,

when I start amarok -d  there are no messages and I don't see any log file in my home directory or in /var/log. Nothing also in journalctl.
Do I miss something?

in mysql log for mariadb nothing related to amarok.
The problem is reproductible on my system:
I take a track from the local collection and via double clicking or a move I add it to the playlist. The lyrics are not displayed in context->lyrics for the current playing track and also not in the track details.
I quit amarok and reload it. For the tracks in the playlist the lyrics are displayed in the track detail and in the context->lyrics.
If I add a new track the lyrics are not displayed.

I confirm also that the lyrics are present in the DB : I can see it in the lyrics using the tracks.url value with this SQL request:
MariaDB [amarokdb]> select lyrics.lyrics, tracks.url from lyrics, tracks where tracks.url= lyrics.url and  tracks.title="De la main gauche";

Do you need some other actions or data?

Regards
Philippe
Comment 4 Philippe Conde 2020-04-21 15:13:13 UTC
Hello,

I created a new user, a new DB in mariadb for amarok, and used the same local directories as user collection
I imported the files in amarok.
I can see thereafter that the db is filled with the data but no lyrics. This seems OK.

I added some tracks in the playlist and tried to insert the lyrics ==> no error but the lyrics table is not filled.

Quit amarok and reload it.
Select one of the tracks in the playlist and insert the lyrics==> success
playing the track I see the lyrics in the context->lyrics.

So this seems to confirm my finding.
Any advice?

Many thanks in advance
Philippe
Comment 5 Pedro de Carvalho Gomes 2020-04-25 09:26:19 UTC
Hi Philippe,

Only today I could take a careful look at the lyrics issue. Basically, there's no support for cached (stored in db) lyrics after the port to KF5 yet. I won't retrieve nor store lyrics at DB. The only available support at this point is to retrieve from lyrics.fandom.com (that's what I was looking at my Opensuse)

I might re-implement this. But I have other functionalities that have higher priority before. If you're a programmer and would like to take a look, I can gladly help you here.
Comment 6 Philippe Conde 2020-04-25 20:38:15 UTC
Hi Pedro,

thanks for your answer. I'm a programmer but I don't have enough knowledge in C++ and QT5 to update such big application as Amarok. 
I had a look in the sources and I have already found some settings for the lyrics: font size, text alignment  etc.

I'll try to find how the lyrics are retrieved  for the tracks in the playlist by the start of amarok.
I'm sure that it is not coming from lyrics.fandom.com but from the DB because I wrote the lyrics form some live tracks which are different from the standard CD tracks.
Most of my collection is in french and related to unpopular or protesting singers,  and the lyrics are mostly not found on lyrics.fandom.com

Many thanks for your work.
Philippe Condé