Bug 419408 - The desktop tabbox should not be displayed when already showing the desktop
Summary: The desktop tabbox should not be displayed when already showing the desktop
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: tabbox (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-30 06:26 UTC by digl
Modified: 2024-02-06 17:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
selectedDesktop(alt+tab) (247.47 KB, image/jpeg)
2020-03-31 11:32 UTC, digl
Details
DesktopThumnail (257.93 KB, image/jpeg)
2020-03-31 11:34 UTC, digl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description digl 2020-03-30 06:26:08 UTC
SUMMARY
In the switching mode (tabbox window mode is switched to the same group mode of the current window), the desktop tabbox should not be displayed, because the desktop does not belong to tabbox.

STEPS TO REPRODUCE
Set configuration ShowDesktopMode to ShowDesktopClient, run the kwin_X11 program, and switch tabbox window mode to the same group mode of the current window in desktop tabbox highlight, can reproduce the problem easily. 

OBSERVED RESULT
the desktop tabbox is displayed.

EXPECTED RESULT
desktop tabbox should not be displayed, no response to this operation.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 digl 2020-03-30 07:16:57 UTC
I've submitted a patch here https://phabricator.kde.org/D28419
Comment 2 Vlad Zahorodnii 2020-03-30 13:43:59 UTC
Could you please clarify what you mean by "desktop tabbox"?
Comment 3 digl 2020-03-31 00:55:31 UTC
(In reply to Vlad Zahorodnii from comment #2)
> Could you please clarify what you mean by "desktop tabbox"?

I mean the desktop thumbnail in the mode switch. Can you understand this explanation?
Comment 4 digl 2020-03-31 02:44:12 UTC
(In reply to Vlad Zahorodnii from comment #2)
> Could you please clarify what you mean by "desktop tabbox"?

I'm sorry, maybe it's not very clear. 
Here's another description:
If the display desktop option is enabled, tabbox should not be switched to application grouping mode when the current index points to desktop item.
Comment 5 Vlad Zahorodnii 2020-03-31 07:26:33 UTC
(In reply to digl from comment #4)
> I'm sorry, maybe it's not very clear. 
> Here's another description:
> If the display desktop option is enabled, tabbox should not be switched to
> application grouping mode when the current index points to desktop item.

I think it's intentional. When the desktop thumbnail is selected, it means "please show me the desktop." If you don't like that windows are moved into the corners, disable the Window Aperture effect or maybe use another effect, e.g. eye On Screen.
Comment 6 digl 2020-03-31 11:22:40 UTC
>  When the desktop thumbnail is selected, it means "please show me the desktop." 

maybe there is a misunderstanding here. I know that 'desktop thumbnail' means 'showing the desktop', and that's just fine. what I mean is that when current tabbing item is 'desktop thumbnail', and by holding alt modifier and pressing back-tilda, it switches to 'group window switching mode', and show a empty list, since there is nothing to show.
Comment 7 digl 2020-03-31 11:32:37 UTC
Created attachment 127132 [details]
selectedDesktop(alt+tab)

This is the attachment when desktop is selected
Comment 8 digl 2020-03-31 11:34:29 UTC
Created attachment 127133 [details]
DesktopThumnail

This is the desktop thumbnail after switching(alt+~)
Comment 9 Nate Graham 2023-07-04 13:55:54 UTC
Git commit b31baaf0cd33b0e4469e67a804d2686b13f41b7a by Nate Graham, on behalf of Daniel Lipovetsky.
Committed on 04/07/2023 at 13:38.
Pushed by ngraham into branch 'master'.

tabbox: Show window switcher only when there are two or more windows

Previously, we showed the window switcher even if there was only one
window, or no windows.

Now, we show the window switcher only if there are two or more windows.
Note that "desktop" counts as a window when the switcher's "show desktop
mode" is enabled.
Related: bug 370396

M  +7    -0    src/tabbox/tabbox.cpp

https://invent.kde.org/plasma/kwin/-/commit/b31baaf0cd33b0e4469e67a804d2686b13f41b7a
Comment 10 Bug Janitor Service 2024-02-06 12:28:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5121
Comment 11 Vlad Zahorodnii 2024-02-06 16:09:24 UTC
Git commit 8086707d1c1799678f445da1fc4029b40e167981 by Vlad Zahorodnii.
Committed on 06/02/2024 at 15:59.
Pushed by vladz into branch 'master'.

Revert "tabbox: Show window switcher only when there are two or more windows"

This reverts commit b31baaf0cd33b0e4469e67a804d2686b13f41b7a.

It's still a good idea to show the task switcher even if there's only
one window in order to provide the user feedback about their action.
Since the task switcher is not shown when there's only one window, it
can be confusing and lead to thinking that the task switcher is broken.
It also fixes a regression which prevents alt-tabbing to the only
remaining minimized window.
Related: bug 480940

M  +0    -7    src/tabbox/tabbox.cpp

https://invent.kde.org/plasma/kwin/-/commit/8086707d1c1799678f445da1fc4029b40e167981
Comment 12 Bug Janitor Service 2024-02-06 16:14:18 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5127
Comment 13 Nate Graham 2024-02-06 16:17:42 UTC
The change was reverted as people found it awkward, so this is now considered intentional, I'm afraid.
Comment 14 Vlad Zahorodnii 2024-02-06 16:23:05 UTC
Git commit 8a932da1f4be2ce581c38c3d82a6646463fe72c2 by Vlad Zahorodnii.
Committed on 06/02/2024 at 16:14.
Pushed by vladz into branch 'Plasma/6.0'.

Revert "tabbox: Show window switcher only when there are two or more windows"

This reverts commit b31baaf0cd33b0e4469e67a804d2686b13f41b7a.

It's still a good idea to show the task switcher even if there's only
one window in order to provide the user feedback about their action.
Since the task switcher is not shown when there's only one window, it
can be confusing and lead to thinking that the task switcher is broken.
It also fixes a regression which prevents alt-tabbing to the only
remaining minimized window.
Related: bug 480940


(cherry picked from commit 8086707d1c1799678f445da1fc4029b40e167981)

M  +0    -7    src/tabbox/tabbox.cpp

https://invent.kde.org/plasma/kwin/-/commit/8a932da1f4be2ce581c38c3d82a6646463fe72c2
Comment 15 Vlad Zahorodnii 2024-02-06 17:45:34 UTC
Git commit 3714dcc3374227cf7e66d2020f55794c45a7fc06 by Vlad Zahorodnii.
Committed on 06/02/2024 at 16:28.
Pushed by vladz into branch 'master'.

tabbox: Prevent including "show desktop" entry if there are no other windows

M  +2    -1    src/tabbox/clientmodel.cpp

https://invent.kde.org/plasma/kwin/-/commit/3714dcc3374227cf7e66d2020f55794c45a7fc06