Created attachment 127084 [details] screenshot krita next b1b691b sometimes already undone strokes stay on canvas and only get updated when drawn over
I have this too, it happens very rarely. opengl on, instant preview disabled...
i have opengl on, but idk about instant preview. yeah it happens rarely, but it happened 2 times after updating krita so i thought it might be more common now. i haven't had this issue in a long time, but it's not a big deal after all
it feels like it's pretty reproducible for me atm... my method is: -create a 3840 x 2160 px canvas -make scribbles across the canvas -zoom in to 50% (idk how but it feels like it happens only at this zoom) -undo in rapid succession
it also happened again at 33% so that doesn't seem to be related after all. what's worse though is that it crashed after pressing redo now.
The regression is caused by 82956f8bcccf5580fd3712df2d5d03cec73ccd14. The cleanup stroke breaks the sequence of undo information.
Git commit 63af6bb0961dcd07b89e8150c6e2644dafb0e46c by Dmitry Kazakov. Committed on 16/04/2020 at 18:33. Pushed by dkazakov into branch 'master'. Disable automatical purging of default pixels It breaks undo on layer's paint devices M +7 -0 libs/image/kis_image.cc M +7 -1 libs/ui/KisDocument.cpp https://invent.kde.org/kde/krita/commit/63af6bb0961dcd07b89e8150c6e2644dafb0e46c
Git commit adbe90fd47dc81173a3442c0d920dcc2dddd4a75 by Dmitry Kazakov. Committed on 16/04/2020 at 18:33. Pushed by dkazakov into branch 'master'. Make sanity checks in KisTiledDataManager more strict We should check if the memento saved in the transaction is still in sync with the revision history of the memento manager. M +15 -7 libs/image/tiles3/kis_memento_manager.cc M +2 -2 libs/image/tiles3/kis_memento_manager.h M +2 -2 libs/image/tiles3/kis_tiled_data_manager.h https://invent.kde.org/kde/krita/commit/adbe90fd47dc81173a3442c0d920dcc2dddd4a75
Git commit b1eff1bd0fc32404139691112702aee46823e58a by Dmitry Kazakov. Committed on 16/04/2020 at 18:37. Pushed by dkazakov into branch 'krita/4.3'. Disable automatical purging of default pixels It breaks undo on layer's paint devices M +7 -0 libs/image/kis_image.cc M +7 -1 libs/ui/KisDocument.cpp https://invent.kde.org/kde/krita/commit/b1eff1bd0fc32404139691112702aee46823e58a
Git commit 752cd71f582adff822526bf5a4c74935d676c87e by Dmitry Kazakov. Committed on 16/04/2020 at 18:45. Pushed by dkazakov into branch 'krita/4.3'. Make sanity checks in KisTiledDataManager more strict We should check if the memento saved in the transaction is still in sync with the revision history of the memento manager. # Conflicts: # libs/image/tiles3/kis_memento_manager.cc M +16 -8 libs/image/tiles3/kis_memento_manager.cc M +2 -2 libs/image/tiles3/kis_memento_manager.h M +2 -2 libs/image/tiles3/kis_tiled_data_manager.h https://invent.kde.org/kde/krita/commit/752cd71f582adff822526bf5a4c74935d676c87e
The bug is now considered as "fixed". We should implement a better way to clear default pixels of the image.
*** Bug 419891 has been marked as a duplicate of this bug. ***