Bug 419340 - Docker Titlebars don't hide anymore
Summary: Docker Titlebars don't hide anymore
Status: RESOLVED UPSTREAM
Alias: None
Product: krita
Classification: Applications
Component: Dockers (other bugs)
Version First Reported In: 4.2.9
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-28 16:08 UTC by Tepee
Modified: 2020-05-04 12:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Docker titlebars hidden or not with LockAllDockerPanels=true (215.38 KB, image/png)
2020-03-28 16:08 UTC, Tepee 		Details
screenshot of 4.1.7 (372.59 KB, image/png)
2020-03-29 09:18 UTC, Halla Rempt 		Details
2016, 30 december - krita_capture_without_titlebars (287.55 KB, image/jpeg)
2020-04-30 16:51 UTC, Tepee 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tepee 2020-03-28 16:08:49 UTC 
Created attachment 127065 [details]
Docker titlebars hidden or not with LockAllDockerPanels=true

SUMMARY
with previous versions of Krita, I used to hide Docker Titlebars because I find it useless since we have the corresponding tab names.
The manipulation was to add in kritarc file
LockAllDockerPanels=true
(source : https://www.reddit.com/r/krita/comments/92mpyr/usage_with_eye_tracker/e36ws3u/)

But it doesn't work anymore. The trick only hide the close and minimize buttons, not the title. So the height of the Docker stay the same.

STEPS TO REPRODUCE
1. In kritarc file, add at the beginning LockAllDockerPanels=true
2. (re)start Krita

OBSERVED RESULT
Only the close and minimize buttons are hidden, not the title.

EXPECTED RESULT
Docker Titlebars completely hidden.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.18.3
(available in About System)
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2020-03-29 09:18:16 UTC 
Created attachment 127077 [details]
screenshot of 4.1.7

Curious... I've checked with older appimages, 4.1.7, as you can see from this screenshot, and that already shows both tabs and titlebars. And since that's an appimage, it's got Qt baked in. Which version of Krita were you using that supported locking the dockers and actually didn't show the titlebars?
Comment 2 wolthera 2020-04-24 12:29:34 UTC 
waiting for info...
Comment 3 Tepee 2020-04-30 16:51:33 UTC 
Created attachment 128035 [details]
2016, 30 december - krita_capture_without_titlebars

We can see that there is no titlebar.
Comment 4 Tepee 2020-04-30 16:52:31 UTC 
Hello, I am so sorry for the delay in my answer (notif was in spam...).
I made a search of screenshots I would have made with Krita in it.
The firsts I found are dated 2016. I don't know wich version it was, but it was up to date for this period.
I will try to find more recent screenshots.
Comment 5 Bug Janitor Service 2020-05-01 04:33:11 UTC 
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 6 Halla Rempt 2020-05-04 12:34:15 UTC 
Then I know what happened... The difference between 3.x and 4.x is that we had to remove our own titlebar implementation for the dockers because it was completely broken on macOS and gnome :-(. I'm afraid that we just cannot go back to the old implementation because the broken part is deep inside Qt.

Sorry :-(