Bug 419225 - Task Manager's Show in Activities Menu should be identical to KWin's equivalent menu accessed through the window decoration
Summary: Task Manager's Show in Activities Menu should be identical to KWin's equivale...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.17.5
Platform: Debian testing Linux
: NOR minor
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-25 13:02 UTC by Alex
Modified: 2023-04-13 18:24 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2020-03-25 13:02:00 UTC
SUMMARY

The "Show in activities" Menu looks different between kwin and plasma (e.g. the icons-only taskbar).

Kwin uses a radio button for "all activites" and checkboxes for single activities and shows activity icons, the taskbar does not show icons and uses checkboxes for "all activities" and the single activity menu items.

I think the kwin menu should be used for the taskbar menu as well.
Comment 1 Gauthier 2021-10-16 07:18:53 UTC
True that! 

Not a big deal but might be worth addressing along with the need for the feature parity on the "Show in activities" for kwin arising from: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/231
Comment 2 Alex 2021-10-17 13:24:00 UTC
Another thought: Every menu that contains checkboxes should stay open when you click a checkbox, because you may want to (un)check more than one.
Comment 3 Nate Graham 2021-11-23 21:40:52 UTC
This was fixed recently; forward-duping to Bug 445664.

*** This bug has been marked as a duplicate of bug 445664 ***
Comment 4 Alex 2021-11-23 23:48:16 UTC
(In reply to Nate Graham from comment #3)
> This was fixed recently; forward-duping to Bug 445664.
> 
> *** This bug has been marked as a duplicate of bug 445664 ***

Are you sure, the consistency part is addressed? I am not sure in which version I can test (is it in Debian testing already?), but the screenshots in the pull request don't look like it's consistent between the panel and kwin.
Comment 5 Nate Graham 2021-11-24 15:45:24 UTC
No, the consistency issues were not addressed. The feature requested was added but not in exactly the same way. They can't share code unfortunately. However the feature does exist in both places now.
Comment 6 Alex 2021-11-24 15:50:11 UTC
I am unsure what's the current state now. But what I would like to see for usability and consistency are these points:

- KWin and the different task bar implementations should use the same or a similar menu
- "All activities" should be a radiobutton or maybe just a button/menu entry, as it is not an option, but controls other options, i.e., checking "all" checks all others and unchecking one other unchecks "all".
- When adding/removing the window from activities, the menu should stay open. When I have five activities and want to assign the window to three other activities, I currently need to open the menu three times to assign it to other activities and a fourth time to remove it from the current activity.
Comment 7 Nate Graham 2021-11-24 16:12:37 UTC
Let's please try to keep a bug reports about a single thing. When bug reports ask for or discuss multiple things, then they become messy and un-actionable.
Comment 8 Alex 2021-11-24 16:40:44 UTC
This bug report always just was about one thing: Consistency of the menus.

That's why I don't understand (as long as the patch didn't involve the suggested UX change, what it does not according to the screenshots in the pull request) yet why it was closed together with a bugreport about a not functioning menu, what never was the issue here (and for me both menus always worked and I only suggesting improving the UX a bit).
Comment 9 Nate Graham 2021-11-24 20:50:58 UTC
OK, re-opening. Ideally they would share code so that consistency could be achieved truly automatically. That's hard though because one lives in KWin and is a QMenu, and the other lives in Plasma and is a QML-based menu.
Comment 11 Alex 2023-04-11 21:40:40 UTC
In Plasma 5.27.2 the menus work as expected, but the title bar menu has icons and the panel menu does not have icons.
I reopen here, as the bug was about consistency and talking about identical menus, which still has this minor issue that can probably be fixed easily.
Comment 12 Nate Graham 2023-04-13 16:19:31 UTC
Got it, will fix.
Comment 13 Bug Janitor Service 2023-04-13 16:36:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/771
Comment 14 Bug Janitor Service 2023-04-13 16:39:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2825
Comment 15 Bug Janitor Service 2023-04-13 16:43:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1473
Comment 16 Nate Graham 2023-04-13 16:44:26 UTC
Those three ought to do it. Unfortunately they'll have to be merged only for Plasma 6; we can't backport to Plasma 5.27.5
Comment 17 Alex 2023-04-13 16:46:49 UTC
Fine! No needs for backports. The menu works as it should and was only slightly inconsistent.
Comment 18 Nate Graham 2023-04-13 16:58:11 UTC
Git commit b12a60c15ee99a7c06b6d9a4fd0680d74cb4f35a by Nate Graham.
Committed on 13/04/2023 at 16:46.
Pushed by ngraham into branch 'master'.

applets/taskmanager: show Activity icons in relevant context menu items

The window decoration menu does; the equivalent Task Manager menus
ought to do the same.

Depends on
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2825
FIXED-IN: 6.0

M  +7    -4    applets/taskmanager/package/contents/ui/ContextMenu.qml

https://invent.kde.org/plasma/plasma-desktop/commit/b12a60c15ee99a7c06b6d9a4fd0680d74cb4f35a
Comment 19 Nate Graham 2023-04-13 17:06:59 UTC
Git commit 0c374b486a5e717be01d1e4cbe3ac6ed94a64b6e by Nate Graham.
Committed on 13/04/2023 at 16:46.
Pushed by ngraham into branch 'master'.

libtaskmanager: add activityIcon getter

Needed for accessing activity icons from the Task Manager.

M  +10   -0    libtaskmanager/activityinfo.cpp
M  +8    -0    libtaskmanager/activityinfo.h

https://invent.kde.org/plasma/plasma-workspace/commit/0c374b486a5e717be01d1e4cbe3ac6ed94a64b6e
Comment 20 Bug Janitor Service 2023-04-13 18:00:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2826
Comment 21 Nate Graham 2023-04-13 18:17:32 UTC
Git commit 56e25cce0954970600c4128a236ba4895f8c5e7a by Nate Graham.
Committed on 13/04/2023 at 18:00.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/taskmanager: show Activity icons in relevant context menu items

The window decoration menu does; the equivalent Task Manager menus
ought to do the same.

Depends on
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2825
FIXED-IN: 6.0


(cherry picked from commit b12a60c15ee99a7c06b6d9a4fd0680d74cb4f35a)

M  +7    -4    applets/taskmanager/package/contents/ui/ContextMenu.qml

https://invent.kde.org/plasma/plasma-desktop/commit/56e25cce0954970600c4128a236ba4895f8c5e7a
Comment 22 Nate Graham 2023-04-13 18:22:22 UTC
Git commit e3f688661309e732baa540c9bbb19476307f267e by Nate Graham.
Committed on 13/04/2023 at 17:54.
Pushed by ngraham into branch 'Plasma/5.27'.

libtaskmanager: add activityIcon getter

Needed for accessing activity icons from the Task Manager.


(cherry picked from commit 0c374b486a5e717be01d1e4cbe3ac6ed94a64b6e)

M  +10   -0    libtaskmanager/activityinfo.cpp
M  +8    -0    libtaskmanager/activityinfo.h

https://invent.kde.org/plasma/plasma-workspace/commit/e3f688661309e732baa540c9bbb19476307f267e
Comment 23 Nate Graham 2023-04-13 18:24:08 UTC
In fact I was wrong; it was backportable and the fix will show up in Plasma 5.27.5