Confirmed.

I think the easiest solution is to remove the checkmark. I don’t know other toolbars which draw a checkmark on checked buttons, and most time the toolbar is not visible anyway. I think the “down” look of the button is sufficient.

By the way there is also a PresentationSearchBar, which looks fine. (You need a find link to open it: https://warwick.ac.uk/fac/sci/physics/research/cfsa/people/pastmembers/wuensch/workshoplatex/beamertutorialkwuensch.pdf)

How would the "down" look look?

Probably just needs to use devicePixelRatio on the pixmap in ui/drawingtoolactions.cpp

This was fixed by ef488d334ea9fe55d821c9a400bbe325981cd856, wasn't it?

Fixed with https://invent.kde.org/graphics/okular/-/merge_requests/159

I can’t tell from GitLab on what branch it was landed, the commit from git log does not seem to appear in GitLab. ⇒ GitLab confuses me.

git log in turn does not show the commit from GitLab. But I can revert the fix on okular/master, where it was commited on master, so I mark this as fixed in 20.08.

The commit in git log does not show the BUG shortcut line, that’s why this was not closed.

Created attachment 129167 [details]
Landed on 20.04 branch

GitLab tells you which branch it landed on. See the attachment.

As for why the bug wasn't automatically closed, it's because for single-commit merge requests, the final commit message is taken from that commit, not the Merge Request description (as Phabricator did) and you only added the BUG keyword into the MR description, not in the commit message of the original commit. The Merge Request description can only be turned into the final commit message when clicking on the Merge button in the web UI if there are more than one commit and you do a squash merge and rewrite the commit message.

Yes, this is a bit confusing. I have documented it at https://community.kde.org/Infrastructure/GitLab#Write_a_good_commit_message to the best of my abilities and files a bug on GitLab itself: https://gitlab.com/gitlab-org/gitlab/-/issues/219747

In the meantime, we need to get in the habit of writing the original commit message as if it was going to be added verbatim into the git history (because now with GitLab, sometimes it will be).

An additional source of confusion arrives from the fact that Okular does not use the same version number as the release service, as nearly all other apps using it do. So version 20.04 of the release service corresponds to Okular 1.10. The next minor version to be tagged is 20.04.3, which corresponds to Okular 1.10.3. Hence, this fix will land in Okular 1.10.3.

If this confuses you as much as it confuses me, talk to Albert about it. :)

Created attachment 129170 [details]
Confusion in GitLab

Nevermind, fixed with https://invent.kde.org/graphics/okular/-/merge_requests/147

I even managed to spawn another search result (!159), which will add to even more confusion right now: GitLab shows me two more commits, confuses me a bit here and there, but at least shows me that it landed on master. I assume my hippo understood it all from the beginning.

I fix this fix release back to my version, if you don’t mind.

Haha! I love the hippo. In that screenshot, you can see:

> Request to merge davidhurka:make-presentation-toolbar-checkboxes-sharp
> into master"
So it would have landed on the master branch after merging.

The actual commit page (https://invent.kde.org/graphics/okular/-/commit/e667143ef10913960d16adb672260ba3edb5c605) is not very clear about what branch it's on though, that's true.

(In reply to Nate Graham from comment #9)
> Haha! I love the hippo. In that screenshot, you can see:
> 
> > Request to merge davidhurka:make-presentation-toolbar-checkboxes-sharp
> > into master"
> So it would have landed on the master branch after merging.
> 
> The actual commit page
> (https://invent.kde.org/graphics/okular/-/commit/
> e667143ef10913960d16adb672260ba3edb5c605) is not very clear about what
> branch it's on though, that's true.

That commit didn't make it to any branch

$ git branch --contains e667143ef10913960d16adb672260ba3edb5c605
error: no such commit e667143ef10913960d16adb672260ba3edb5c605

that's because the MR was squashed.

It's true in that case there's not really lots of info, all you can do is

go to https://invent.kde.org/graphics/okular/-/commit/e667143ef10913960d16adb672260ba3edb5c605

see that it's part of https://invent.kde.org/graphics/okular/-/merge_requests/147

and see that it says " The changes were merged into master "

I would hope it actually points to the squashed commit created by that MR but I can't seem to find a way for it