Created attachment 126987 [details] Crashlog SUMMARY Krita crashes when attempts undo after clearing Assistants, deleting assistant individually doesnt causes crash. STEPS TO REPRODUCE Using the assistant tools to create an assistant. Press the delete all assistant button/clear assistant. Undo OBSERVED RESULT It Crashes. EXPECTED RESULT Should have restored the assistant, or just skip the undo. SOFTWARE/OS VERSIONS Windows: Windows 10 ADDITIONAL INFORMATION HardWare: Acer Aspire Swift 3. MX150 card, i5 cpu, 8 gigs of ram.
I can confirm this on 4.2.8, the 4.2.9 beta. My compiled master build gives me an assert: ASSERT (krita): "curAssistants.size() == assistants.size() + 1" in file /home/appimage/persistent/krita/plugins/assistants/Assistants/EditAssistantsCommand.cpp, line 62
Note: the assert should not be present in release builds, but just removing them doesn't make undo work. There's a bit of work here.
Git commit 8e3f993a77b129e5b5406e753b34efc8b5d4c719 by Emmet O'Neill. Committed on 05/05/2020 at 01:46. Pushed by emmetoneill into branch 'master'. Fixed bad assertion and failure to undo removeAllAssistants. KisAssistantTool::removeAllAssistants function wasn't making correct use of EditAssistantsCommand. EditAssistantsCommand also contained a flawed and unnecessary assertion. Thanks for the help Eoin. M +10 -11 plugins/assistants/Assistants/EditAssistantsCommand.cpp M +6 -5 plugins/assistants/Assistants/kis_assistant_tool.cc https://invent.kde.org/kde/krita/commit/8e3f993a77b129e5b5406e753b34efc8b5d4c719
Git commit 0ac7f9fde8f1bbfc4823d03753d47fc43b059e74 by Boudewijn Rempt, on behalf of Emmet O'Neill. Committed on 05/05/2020 at 07:27. Pushed by rempt into branch 'krita/4.3'. Fixed bad assertion and failure to undo removeAllAssistants. KisAssistantTool::removeAllAssistants function wasn't making correct use of EditAssistantsCommand. EditAssistantsCommand also contained a flawed and unnecessary assertion. Thanks for the help Eoin. (cherry picked from commit 8e3f993a77b129e5b5406e753b34efc8b5d4c719) M +10 -11 plugins/assistants/Assistants/EditAssistantsCommand.cpp M +6 -5 plugins/assistants/Assistants/kis_assistant_tool.cc https://invent.kde.org/kde/krita/commit/0ac7f9fde8f1bbfc4823d03753d47fc43b059e74