Bug 419168 - Changing color schemes only partially works until logout/restart (native applications).
Summary: Changing color schemes only partially works until logout/restart (native appl...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.18.3
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-24 05:38 UTC by info
Modified: 2020-04-15 13:49 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description info 2020-03-24 05:38:09 UTC
SUMMARY
Changing from one colour scheme to another in system settings doesn't fully update colours in native applications until I've logged out and in again or restarted the system. Editing a colour scheme produces the same result. Sometimes switching to another colour scheme then back to the desired one can help, but results are inconsistent.

STEPS TO REPRODUCE
1. Select colour scheme. Hit apply.
2. Observe that some but not all colours have changed in native applications.
3. Switch to another colour scheme. Same result.
4. Restart system. Colour scheme is now accurate.

OBSERVED RESULT
Colour schemes only update partially when settings are applied. (progress bars especially are a problem)

EXPECTED RESULT
Colour schemes should be updated immediately & completely to the selected scheme.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 4.15.0-91-generic / KDE Neon
(available in About System)
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
This also happens with icon sets. Happy to test further if necessary.
Comment 1 Kai Uwe Broulik 2020-03-24 08:12:44 UTC
Which applications are affected by this?
Comment 2 info 2020-03-24 23:21:26 UTC
So I went through a bit more carefully and it looks like things fell into two categories.

1. Clicking the apply button when editing a colour scheme does nothing until I change to another colour scheme then change back to the one I just edited.

2. The cantata scrollbar doesn't change colour until I reboot/relog. I have a reasonably clear memory of this being the case with other UI elements, but the current behaviour doesn't bear this out on testing. I tried a few different qt apps but wasn't able to replicate the issue in anything except cantata. Realised I wasn't using the latest version of cantata (2.20 vs 2.40). Updated cantata and it seems to be working as expected now so it looks like the only issue is that the apply button in the "edit colour schemes" menu doesn't work.

For icons: Dolphin and Krusader both only change some icons. A few more may or may not populate the UI after navigating through a few directories, but it'll take a reset to fully update them. It's likely that more apps exhibit this behaviour, but these are the apps I have installed that use system icons.

It might make sense to treat the icon issue as a separate bug, but I figure it's worth mentioning here in case they share a common cause and it helps to identify what that might be. Happy to file separate reports if it makes sense to do so.
Comment 3 info 2020-03-25 00:10:55 UTC
Scratch that. Cantata's play-progress bar (not the scroll bar. Meant to type progress bar and typed scroll bar) is still changing colour inconsistently, but less so. This might be something to take up with the cantata developer though if I'm not able to find a similar behaviour in other apps.
Comment 4 Kai Uwe Broulik 2020-03-25 08:35:26 UTC
Can confirm 1. I fixed the Apply button not enabling but apparently I forgot to set the dirty flag, too

Not sure about Cantata but it might be doing some custom painting/palette stuff there? Can you try with a more traditional KDE application?

As for the icons, yes, please file this as a separate bug.
Comment 5 Kai Uwe Broulik 2020-03-25 09:41:54 UTC
Git commit d0f673d0e92b297afb6cd0efa7547d256d3a6252 by Kai Uwe Broulik.
Committed on 25/03/2020 at 09:41.
Pushed by broulik into branch 'Plasma/5.18'.

[Colors KCM] Also save colors when active scheme was edited

I fixed the case that the "Apply" button wasn't enabled when the selected scheme didn't change but was edited by introducing the m_activeSchemeEdited variable.
However, I didn't actually have it save in this case...

Differential Revision: https://phabricator.kde.org/D28270

M  +1    -1    kcms/colors/colors.cpp

https://commits.kde.org/plasma-desktop/d0f673d0e92b297afb6cd0efa7547d256d3a6252
Comment 6 Nate Graham 2020-04-15 13:49:16 UTC
Fixed on the KDE side now. Apps that don't change properly need to be fixed individually to be more standards-compliant.