Bug 418997 - s390x: Support Iex_ITE for float and vector types
Summary: s390x: Support Iex_ITE for float and vector types
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Andreas Arnez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-18 18:41 UTC by Andreas Arnez
Modified: 2020-04-08 15:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Support Iex_ITE for float and vector types (4.46 KB, patch)
2020-03-25 11:47 UTC, Andreas Arnez 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Arnez 2020-03-18 18:41:25 UTC 
After fixing problems with the register allocation that affected "grail" on s390x (Bug 417281), "grail" still shows problems on s390x, due to missing support for Iex_ITE expressions for anything else but integer types.  Failures look like this:

ITE(t30,t31,t4)
vex: the `impossible' happened:
   s390_isel_float_expr: cannot reduce tree
Comment 1 Andreas Arnez 2020-03-25 11:47:58 UTC 
Created attachment 127000 [details]
Support Iex_ITE for float and vector types

This patch fixes the fails I have seen.
Comment 2 Andreas Arnez 2020-04-01 17:35:14 UTC 
If there are no objections, I'm going to push this.
Comment 3 Andreas Arnez 2020-04-08 15:10:37 UTC 
OK, pushed as git commit abe7f083fdebb40c6f4a5adbdd2b64f5c329969a.