Bug 418974 - Corruption of project by broken association between video and audio clips
Summary: Corruption of project by broken association between video and audio clips
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: git-master
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-18 00:48 UTC by alriddoch
Modified: 2020-03-22 18:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing corrupted project loaded into latest nightly at time of filing (604.03 KB, image/png)
2020-03-18 00:48 UTC, alriddoch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description alriddoch 2020-03-18 00:48:41 UTC
Created attachment 126861 [details]
Screenshot showing corrupted project loaded into latest nightly at time of filing

SUMMARY

When a project is loaded, the association between video and audio clips with the same origin is broken and corrupted. Saving the project makes this corruption permanent. This bug is present in kdenlive-20.07.70-f1def35-x86_64.appimage but not present in kdenlive-19.12.3-x86_64.appimage.

DETAILS

In the new timeline, video and audio clips have separate tracks, and when a clip is added from a source which has both audio and video, two associated clips are created on the timeline, one audio, one video. The two associated clips are grouped so that they automatically move together, and selecting and editing one also edits the other.

When a project is loaded into the latest nightly build (kdenlive-20.07.70-f1def35-x86_64.appimage) the clip groupings don't work, and in some cases clips appear to be grouped with the wrong counterpart clip.


STEPS TO REPRODUCE
1. Load an existing project into kdenlive.
2. Select a video clip on the timeline.
3. 

OBSERVED RESULT

The corresponding audio clip is not selected as well, or another nearby audio clip is selected in addition to the video clip.

EXPECTED RESULT

The corresponding audio clip should also be selected.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

The attached screenshot shows a short project created recently, loaded into kdenlive-20.07.70-f1def35-x86_64.appimage. The dark outline on all the clips on the timeline indicates they are not grouped (as they should be), and the single selected video clip is dis-associated from its corresponding audio. This project works correctly when loaded into kdenlive-19.12.3-x86_64.appimage
Comment 1 alriddoch 2020-03-18 01:13:24 UTC
By binary search, I have tracked the bug down to the following commit:

1ffc0b611ee6425bcac35aa732b702fa93b34c9c "Ensure audio track is inserted at correct position when no previous audio exists"
Comment 2 Jean-Baptiste Mardelle 2020-03-18 08:15:51 UTC
Thanks a lot for your report, I can confirm the issue. Working on it...
Comment 3 Jean-Baptiste Mardelle 2020-03-18 08:28:11 UTC
Git commit c5ae08cd51a166cdcabe3501a42245bcbf91e7fc by Jean-Baptiste Mardelle.
Committed on 18/03/2020 at 08:26.
Pushed by mardelle into branch 'release/20.04'.

Revert commit 1ffc0b61 breaking group loading.

M  +1    -1    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/kde/kdenlive/commit/c5ae08cd51a166cdcabe3501a42245bcbf91e7fc
Comment 4 alriddoch 2020-03-18 09:56:06 UTC
Fix confirmed.

Thanks for the really quick turnaround! Keep up the good work.
Comment 5 emohr 2020-03-22 18:36:07 UTC
Thank you for the feedback and contribution. Glad to hear it works. 

We close this bug. If it still appears in the latest version, please feel free to re-open it and update the affected version number.