Bug 418915 - Allow to rename linked pdf file without moving
Summary: Allow to rename linked pdf file without moving
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: KBibTeX
Classification: Applications
Component: General (other bugs)
Version First Reported In: 0.9
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-16 10:43 UTC by smihael
Modified: 2020-04-01 21:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 0.10
Sentry Crash Report:


Attachments
Renaming dialog (88.39 KB, image/png)
2020-03-16 10:43 UTC, smihael
Details
attachment-17043-0.html (2.67 KB, text/html)
2020-04-01 21:21 UTC, smihael
Details

Note You need to log in before you can comment on or make changes to this bug.
Description smihael 2020-03-16 10:43:15 UTC
Created attachment 126827 [details]
Renaming dialog

SUMMARY
Currently it is only possible to rename pdf if you select to move it next to the library file. This conflicts with organizing pdfs in sub-directories.

STEPS TO REPRODUCE
1. Edit an entry
2. Select External tab
3. Add a file


OBSERVED RESULT
See screenshot. Renaming file to match the element id is only possible if user selects to move file next to the bib file.

EXPECTED RESULT
See summary. It should be possible to raneme pdf file within the source directory.
Comment 1 Thomas Fischer 2020-03-16 22:09:36 UTC
This is a reasonable feature request. I tried to implement it in a feature branch for KBibTeX 0.10. It won't be part of 0.9.2 as I want to conclude the 0.9.x without much changes.

You can test this code without interfering with your default KBibTeX installation by following the "quick start" instructions:
https://userbase.kde.org/KBibTeX/Development#Quick_Start_to_Run_KBibTeX_from_Git

To test the Git version containing the fix for your bug, please run the following command (all in one line):
bash run-kbibtex.sh https://anongit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git bugs/kde418915

Let me know if those changes actually work and satisfy your expectations.
Comment 2 Thomas Fischer 2020-03-31 20:29:05 UTC
Did you have any chance to test if the change satisfies your request?

(In reply to Thomas Fischer from comment #1)
> This is a reasonable feature request. I tried to implement it in a feature
> branch for KBibTeX 0.10. It won't be part of 0.9.2 as I want to conclude the
> 0.9.x without much changes.
> 
> You can test this code without interfering with your default KBibTeX
> installation by following the "quick start" instructions:
> https://userbase.kde.org/KBibTeX/
> Development#Quick_Start_to_Run_KBibTeX_from_Git
> 
> To test the Git version containing the fix for your bug, please run the
> following command (all in one line):
> bash run-kbibtex.sh
> https://anongit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git
> bugs/kde418915
> 
> Let me know if those changes actually work and satisfy your expectations.
Comment 3 smihael 2020-04-01 21:21:05 UTC
Created attachment 127181 [details]
attachment-17043-0.html

Thanks for the patch. Unfortunately, I haven't had a chance to set up a
development environment as I'm busy with writing at the moment. I will get
bask to this as soon as I can.

On Tue, 31 Mar 2020 at 22:29, Thomas Fischer <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=418915
>
> Thomas Fischer <fischer@unix-ag.uni-kl.de> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|ASSIGNED                    |RESOLVED
>       Latest Commit|a8f4ea36bd6bf3de0fca91db5a5
> |3cd8e46751d3dbe203346767e09
>                    |43bbefb7f2812               |e9c01fe7e9aa8
>          Resolution|---                         |WAITINGFORINFO
>
> --- Comment #2 from Thomas Fischer <fischer@unix-ag.uni-kl.de> ---
> Did you have any chance to test if the change satisfies your request?
>
> (In reply to Thomas Fischer from comment #1)
> > This is a reasonable feature request. I tried to implement it in a
> feature
> > branch for KBibTeX 0.10. It won't be part of 0.9.2 as I want to conclude
> the
> > 0.9.x without much changes.
> >
> > You can test this code without interfering with your default KBibTeX
> > installation by following the "quick start" instructions:
> > https://userbase.kde.org/KBibTeX/
> > Development#Quick_Start_to_Run_KBibTeX_from_Git
> >
> > To test the Git version containing the fix for your bug, please run the
> > following command (all in one line):
> > bash run-kbibtex.sh
> > https://anongit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git
> > bugs/kde418915
> >
> > Let me know if those changes actually work and satisfy your expectations.
>
> --
> You are receiving this mail because:
> You reported the bug.