Bug 418700 - Panel thickness very difficult to adjust/configure
Summary: Panel thickness very difficult to adjust/configure
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.18.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-03-10 10:35 UTC by Michael D
Modified: 2020-06-12 14:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2020-03-10 10:35:07 UTC
Configuring panel height is extremely difficult, especially using a touchpad. It takes unreasonable effort to set it to a desired pixel height because very small movement (a pixel or two) changes the height. An option to manually enter a height in pixels would help.
Comment 1 Nate Graham 2020-05-08 16:10:19 UTC
Fixed/implemented with https://phabricator.kde.org/D29535
Comment 2 Michael D 2020-05-08 19:07:01 UTC
Very nice. In my opinion, forget about keeping the drag-to-resize functionality--what you've implemented on phabricator is significantly better.
Comment 3 Nate Graham 2020-06-12 14:47:13 UTC
Git commit 876eedfb6b93a2d18a91ed0d734839eed01e9947 by Nate Graham.
Committed on 12/06/2020 at 14:47.
Pushed by ngraham into branch 'master'.

Add a SpinBox (with draggability) to panel thickness adjustment UI

Summary:
We receive many complaints and bug reports about the current UI for adjusting panel
thickness. People don't figure out that they have to drag on the button, and when they do,
they complain that it's too hard to set the value finely enough.

This patch removes the draggable button and replaces it with a more conventional SpinBox,
which in D29534 is given ability to adjust the values by scrolling over it or clicking and
dragging. This yields the following improvements:
- The way you adjust panel thickness is now more obvious
- The existing drag-to-adjust behavior is much nicer and less buggy
- Panel thickness can now be specified numerically
- Fine-tuning panel thickness is now easier using any adjustment method
- We have one fewer custom control to maintain
- Bugs in custom scrolling implementation go away

Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design
with large touchable buttons that can be held down to quickly adjust the value, and touch-and
-drag still works after D29534 is applied.

I wouldn't mind using this SpinBox design elsewhere too; see T9460.
Related: bug 421169
FIXED-IN: 5.19

Test Plan:
{F8301480}
{F8301388}

Reviewers: abetts, #vdg, #plasma, mart

Reviewed By: #vdg, #plasma, mart

Subscribers: mart, ahiemstra, cblack, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29535

D  +0    -181  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
M  +43   -6    desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

https://invent.kde.org/plasma/plasma-desktop/commit/876eedfb6b93a2d18a91ed0d734839eed01e9947