Bug 418650 - Not correct direction of Inner Shadow or no correct tip
Summary: Not correct direction of Inner Shadow or no correct tip
Status: RESOLVED NOT A BUG
Alias: None
Product: krita
Classification: Applications
Component: layer styles (other bugs)
Version First Reported In: 4.2.8
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-09 04:14 UTC by Kirill Kustov
Modified: 2020-04-24 12:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Wrong Inner Shadow (102.15 KB, image/png)
2020-03-09 04:14 UTC, Kirill Kustov
Details
Correct Inner Shadow (119.36 KB, image/png)
2020-03-09 04:15 UTC, Kirill Kustov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Kustov 2020-03-09 04:14:08 UTC
Created attachment 126683 [details]
Wrong Inner Shadow

SUMMARY
The direction of Inner Shadow doesn't fit angle control. It has to show the contrary result.

STEPS TO REPRODUCE
1. Create a document.
2. Draw Circle on Layer #1.
3. Welcome to Layer Styles of Layer #1.
4. Turn on Inner Shadow and play with Angle.
5. Wait for the rerendering preview.

OBSERVED RESULT
Inner Shadow is displayed on the wrong side of the circle.

EXPECTED RESULT
Inner Shadow is displayed on another side of the circle.

SOFTWARE/OS VERSIONS
Windows: Windows 10

ADDITIONAL INFORMATION
The control shows us the direction a point of light to the object, then Inner Shadow has to appear on another side of the object, not a light side.
Comment 1 Kirill Kustov 2020-03-09 04:15:24 UTC
Created attachment 126684 [details]
Correct Inner Shadow
Comment 2 Ahab Greybeard 2020-03-09 18:21:47 UTC
This is an Inner Shadow. If you consider Drop Shadow, which has the 'opposite' effect, then Inner Shadow is its complement and represents a shadow cast inside the object by its outer edges?
Comment 3 Kirill Kustov 2020-03-09 23:44:03 UTC
I consider the controller of angle and position of Inner Shadow. The black point of the controller angle shows us the angle of light dropping on the ball/circle. This information I read at the tip when I position the mouse on the black point of the controller ("Set the angle of the light source").  If the black point is the light source It means that ray of light spread from the up-right corner to the down-left corner. And Inner Shadow must be drawn down-left corner of ball/circle.
Now Inner Shadow is drawn on the light side od ball/circle - it is a bug.

Now it controller shows us the "Position of the shadow", not the light source how tip shows us.

ps. Drop Shadow must be drawn down-left corner too if the position of the controller the same.

In general, there is an illogical situation in the tip and drawing Inner shadow.

I see two cases to fix the bug:
1. Rewrite tip to "Position of the shadow" - simple, but interface will be less logical (I mean Drop shadow, etc. Tips will differ. User will be confused too. He doesn't always look at the tip, he expect the tip has the same value - "Set the angle of the light source".).
2. Fix shadow.

In both cases it'll fix the bug and interface will be more (second case) or less (first case) logical.

Sorry for my English mistakes if any. I hope I clearly showed the bug that I mean.
Comment 4 Kirill Kustov 2020-03-10 06:02:48 UTC
Also, you can turn the global light on and you'll see this bug the inner shadow is opposite drop shadow when light rays beam from the up-right corner.
Comment 5 Ahab Greybeard 2020-03-10 09:38:32 UTC
For me, the setting of Global Light does not make any difference.
I think the behaviour of Inner Shadow must be compared to that produced by other well known applications that produce this effect to see what the 'standard' is.
I must leave that to someone else.
Comment 6 Kirill Kustov 2020-03-10 11:18:05 UTC
I have no PS, but I see the video. There is have the same function in PS. Perhaps it has a tip - 'Angle' - solution to this situation, this solution decide all questions. But I don't think tip shows us "Set the angle of the light source" in PS. I don't know. Although everything can be. As I have said I have no PS.

For me 'standard' is simply and logically. If one of these conditions does not execute it's not 'standard'.
Comment 7 wolthera 2020-04-24 12:43:57 UTC
No, I am sorry, it is correct and consistent with PS.