Bug 418648 - Partition colour scheme is not applied to secondary (MBR logical) partitions
Summary: Partition colour scheme is not applied to secondary (MBR logical) partitions
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 4.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-08 22:18 UTC by medin
Modified: 2020-10-05 17:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Difficulty to read sizes with dark breeze theme (75.24 KB, image/png)
2020-03-08 22:18 UTC, medin
Details
Partition Manager wrong color (154.64 KB, image/png)
2020-03-08 22:54 UTC, medin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2020-03-08 22:18:45 UTC
Created attachment 126680 [details]
Difficulty to read sizes with dark breeze theme

When using dark breeze theme, it's difficult to read the sizes of partitions in Partition Manager GUI. See my attached image for more info.
Comment 1 Andrius Štikonas 2020-03-08 22:21:31 UTC

*** This bug has been marked as a duplicate of bug 408699 ***
Comment 2 Andrius Štikonas 2020-03-08 22:22:17 UTC
Note, that there is a workaround, you can change partition colours yourself.
Comment 3 medin 2020-03-08 22:53:38 UTC
(In reply to Andrius Štikonas from comment #2)
> Note, that there is a workaround, you can change partition colours yourself.

In fact your solution uncovers another bug, those color are not applied to secondary partitions, see my attached image for more info.
Comment 4 medin 2020-03-08 22:54:10 UTC
Created attachment 126681 [details]
Partition Manager wrong color
Comment 5 Andrius Štikonas 2020-03-09 00:30:37 UTC
The bug is likely in partitionmanager src/gui/parttablewidget.cpp in void PartTableWidget::setPartitionTable function.

It seems that for every partition table we are looping over it's children and call w->setFileSystemColorCode(GuiHelpers::fileSystemColorCodesFromSettings());

Yet there is no attempt to iterate over deeper levels of children.
Comment 6 Andrius Štikonas 2020-10-05 17:26:27 UTC
Git commit 02e43598894e300c7d93970f201cfc067f360574 by Andrius Štikonas.
Committed on 05/10/2020 at 17:24.
Pushed by stikonas into branch 'master'.

Apply colour scheme to secondary (MBR logical) partitions

M  +3    -0    src/gui/parttablewidget.cpp

https://invent.kde.org/system/partitionmanager/commit/02e43598894e300c7d93970f201cfc067f360574