SUMMARY If there are more than one path in Elisa settings, we can remove some of them by clicking on their "-" button. The last path can never be removed, its "-" button just blinks when clicked. STEPS TO REPRODUCE 1. open Elisa 2. open its settings by pressing ctrl+shift+, 3. try to remove all listed paths OBSERVED RESULT it's impossible to remove the last path EXPECTED RESULT We should can remove all paths or "-" button should be disabled when only one path is listed. I'm in doubt. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.18.80 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.1
There always needs to be at least one path, or else Elisa doesn't know where to find your music. The UX for this could be improved a bit though.
Will fix this as a part of my (WIP) work to re-do the config window, which needs https://invent.kde.org/multimedia/elisa/-/merge_requests/183 to be merged first.
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/198
Git commit 4043561f2fffc7965c4fdc5f1d0908a39e6ded84 by Nate Graham. Committed on 10/12/2020 at 15:32. Pushed by ngraham into branch 'master'. Redo configuration window The configuration window is re-done in a modern style. The changes include: - Use Form Layout style - Use standard style list delegates - Use standard Kirigami Units for distances, sizes, and paddings - Use an invokable function to remove paths rather than directly manipulating the model from inside the view - Re-word some text for clarity and brevity - Display warning for using filesystem crawling only when the option is selected - Combine everything into a single file for simplicity - Don't let the user remove the last music search path - Re-order properties to conform to standard style - Use QQC2 import name These changes fix the following bugs: Related: bug 425140 FIXED-IN: 21.04 Note that this bumps the frameworks dependency to 5.77 due to the use of the new trailing property in Kirigami.BasicListItem. M +1 -1 CMakeLists.txt M +0 -2 src/CMakeLists.txt M +6 -0 src/localFileConfiguration/elisaconfigurationdialog.cpp M +3 -0 src/localFileConfiguration/elisaconfigurationdialog.h M +252 -50 src/qml/ElisaConfigurationDialog.qml D +0 -159 src/qml/FileScanningConfiguration.qml D +0 -153 src/qml/GeneralConfiguration.qml M +0 -2 src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/4043561f2fffc7965c4fdc5f1d0908a39e6ded84