Bug 418526 - Doesn't show firefox bookmarks
Summary: Doesn't show firefox bookmarks
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: bookmarks (show other bugs)
Version: 5.18.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-06 08:01 UTC by Oleg Solovyov
Modified: 2020-05-27 18:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Solovyov 2020-03-06 08:01:38 UTC
SUMMARY
KRunner doesn't show any firefox bookmarks.

STEPS TO REPRODUCE
1. Create a new user
2. Launch firefox
3. Add a bookmark
4. Open krunner
5. Type bookmark name

OBSERVED RESULT
Bookmark is not listed

EXPECTED RESULT
Bookmark successfully matched and shown

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.5.7-un-def-alt1
(available in About System)
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.12.7
Comment 1 Oleg Solovyov 2020-03-06 08:04:32 UTC
Default profile shown in installs.ini does not match the profile in profiles.ini with given "Default=1"

[altlinux@localhost firefox]$ cat profiles.ini 
[Profile1]
Name=default
IsRelative=1
Path=dun5pnnn.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=xewbk2mp.default-default

[General]
StartWithLastProfile=1
Version=2

[Install11457493C5A56847]
Default=xewbk2mp.default-default
Locked=1

[altlinux@localhost firefox]$ cat installs.ini 
[11457493C5A56847]
Default=xewbk2mp.default-default
Locked=1

[altlinux@localhost firefox]$ pwd
/home/altlinux/.mozilla/firefox
Comment 2 Alexander Lohnau 2020-04-21 06:39:27 UTC
I already know this bug and am working on a patch :-).


If you urgently want it to work you can do the following:

Edit the ~/.config/kdeglobals file

Go to the entry group "[General]"

And change the dbfile entry to:
dbfile=/home/altlinux/.mozilla/firefox/xewbk2mp.default-default/places.sqlite


Then restart KRunner:
kquitapp5 krunner;kstart5 krunner

And it hopefully works.
Comment 3 Thilo 2020-05-26 09:00:39 UTC
(In reply to Alex from comment #2)
> I already know this bug and am working on a patch :-).
> 
> 
> If you urgently want it to work you can do the following:
> 
> Edit the ~/.config/kdeglobals file
> 
> Go to the entry group "[General]"
> 
> And change the dbfile entry to:
> dbfile=/home/altlinux/.mozilla/firefox/xewbk2mp.default-default/places.sqlite
> 
> 
> Then restart KRunner:
> kquitapp5 krunner;kstart5 krunner
> 
> And it hopefully works.

I am facing the same issue (KDE neon) and this fixed it for me
Comment 4 Alexander Lohnau 2020-05-27 15:07:33 UTC
Git commit a960c028c71d710ce00841851a55fb35123c164d by Alexander Lohnau.
Committed on 27/05/2020 at 15:05.
Pushed by alex into branch 'Plasma/5.19'.

Bookmarks Runner: Fix extraction of firefox profile

Summary:

The profile group with the value `Default=1` is not always the default profile, for example in the profiles.ini file from the bug report:
```
[Profile1]
Name=default
IsRelative=1
Path=dun5pnnn.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=xewbk2mp.default-default

[Install11457493C5A56847]
Default=xewbk2mp.default-default
Locked=1```

In the text you can see that the profile with `dun5pnnn.default` has the value `Default=1`,
but it is not  the default profile.
The correct default profile is in the `[Install11457493C5A56847]` group with the key `Default`.

Test Plan:
If you create a new profile it will be extracted as the default profile
(but the old value might still be cached see D28619).

Reviewers: #plasma, ngraham, bruns, broulik, meven

Reviewed By: meven

Subscribers: meven, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29326

M  +10   -5    runners/bookmarks/browsers/firefox.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/a960c028c71d710ce00841851a55fb35123c164d
Comment 5 Alexander Lohnau 2020-05-27 15:11:22 UTC
This will be included in the 5.19 release