Bug 418508 - KMessageBox dialogs invoked by KIOExec need a qApp windowIcon
Summary: KMessageBox dialogs invoked by KIOExec need a qApp windowIcon
Status: CONFIRMED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.67.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-05 19:28 UTC by postix
Modified: 2020-04-13 11:28 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot. (34.94 KB, image/png)
2020-03-05 19:28 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-03-05 19:28:42 UTC
Created attachment 126610 [details]
Screenshot.

SUMMARY

After editing a screenshot, which I exported from Spectacle, in GIMP and closing GIMP, I was kindly asked by KIOExec if I want to keep the modified file.

KIOExec does not have any icon and therefore uses the default icon from X11. It would be prettier if it used the official KDE Plasma logo.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 1 Ahmad Samir 2020-03-12 07:03:03 UTC
I couldn't reproduce this issue. Could you give more detailed steps? (how did you edit it in gimp... etc). Thanks.
Comment 2 postix 2020-03-12 16:29:59 UTC
> Could you give more detailed steps?
Sure!

1) Press print to create a screenshot with Spectacle
2) Choose "Save to" and save it in the proposed home folder
3) At Spectacle choose "Export to GIMP"
4) Press Ctrl+Shift+E to export it in GIMP, overwrite the saved screenshot from Spectacle from Step 2)
5) Close Gimp, discard the question whether to save the project to file

Once GIMP exited, the KIOExec dialog pops up.
Comment 3 postix 2020-03-12 16:33:18 UTC
It does not need to be GIMP, it could also be Gwenview. It's only importend, that the file becomes replaced.

You can also already close Spectacle after step 3).
Comment 4 Patrick Silva 2020-03-13 17:40:06 UTC
Requested info was provided.
Comment 5 Patrick Silva 2020-03-13 19:31:27 UTC
another way to reproduce:
take a screenshot by pressing printscreen key
click on "Export" button and choose Gwenview
crop the screenshot with Gwenview and click on "Save" button on the top bar
close Gwenview and Spectacle
Comment 6 Ahmad Samir 2020-04-08 17:19:00 UTC
Sorry for the delay; I can now reproduce the issue now (I forgot that a long time ago I actually removed the app menu button from the titlebar... very smart of me :)).

On the one hand a KMessageBox ideally uses the icon of the app that triggered it, e.g. it would use the icon of Konsole if Konsole launched a KMessageBox. Here since it's KIOExec, which doesn't have an icon, this issue happens.

An icon could be added to KIOExec, or KMessageBox should use the same icon it displays next to the text as the window icon too... I am not sure.
Comment 7 David Faure 2020-04-13 11:28:08 UTC
You can change the kioexec icon using the --windowicon command line parameter.

You could also add a --winid parameter and use it like KMessageBox::warningContinueCancelWId(winId...) does.