Bug 418483 - Pinned apps move when launched as if using the behavior of the non-Icons-Only Task Manager
Summary: Pinned apps move when launched as if using the behavior of the non-Icons-Only...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Icons-only Task Manager (show other bugs)
Version: 5.18.0
Platform: Other Linux
: VHI major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 403598 413013 413677 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-04 21:07 UTC by Nate Graham
Modified: 2020-04-06 19:30 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.5


Attachments
config file that reproduces the issue (3.50 KB, text/plain)
2020-03-09 14:39 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-03-04 21:07:21 UTC
Reported by a user. Icons in the IOTM behave as though they were pinned launchers in a regular Task Manager: they jump to the end when launched rather than staying where they are. Can reproduce with a clean user account on git master.

Video evidence at https://www.dropbox.com/s/gfit0lupdywd77u/Icons-only%20Task%20Manager%20DOIDO.gif?dl=0
Comment 1 Nate Graham 2020-03-04 21:09:26 UTC
*** Bug 413013 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2020-03-04 21:09:31 UTC
*** Bug 413677 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2020-03-04 21:11:26 UTC
*** Bug 403598 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2020-03-09 14:39:33 UTC
Created attachment 126701 [details]
config file that reproduces the issue
Comment 5 Kai Uwe Broulik 2020-03-09 14:41:46 UTC
I don't see any pinned apps for task manager in that file
Comment 6 Nate Graham 2020-03-09 14:43:52 UTC
Ah yes, they were added in https://phabricator.kde.org/D27845.

Maybe that's the issue then: the launchers need to be defined in the config file, and can't be in the panel defaults.
Comment 7 Marco Martin 2020-04-06 18:18:10 UTC
https://phabricator.kde.org/D28632
Comment 8 Marco Martin 2020-04-06 18:30:31 UTC
Git commit 627920bdfe14e17620a4d1ee99c7d10b028b26bf by Marco Martin.
Committed on 06/04/2020 at 18:30.
Pushed by mart into branch 'master'.

use the decoded url for launcherPosition

Summary:
launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order

Test Plan: firefox stays in first position when pinned as preferred://browser

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28632

M  +1    -1    libtaskmanager/launchertasksmodel.cpp

https://commits.kde.org/plasma-workspace/627920bdfe14e17620a4d1ee99c7d10b028b26bf
Comment 9 Marco Martin 2020-04-06 18:54:12 UTC
Git commit ac0124c48ce685db42ef0a99ce48e4b86621ed12 by Marco Martin.
Committed on 06/04/2020 at 18:54.
Pushed by mart into branch 'Plasma/5.18'.

use the decoded url for launcherPosition

Summary:
launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order

Test Plan: firefox stays in first position when pinned as preferred://browser

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28632

M  +1    -1    libtaskmanager/launchertasksmodel.cpp

https://commits.kde.org/plasma-workspace/ac0124c48ce685db42ef0a99ce48e4b86621ed12