Bug 418416 - Bad theming/colors network manager (connections)
Summary: Bad theming/colors network manager (connections)
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
: 418740 419102 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-02 22:01 UTC by Gabriel Fernandes
Modified: 2020-03-22 10:39 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-nm/7de9e9cdbd57b991226fe7467fbca4841e73e9e0
Version Fixed In: 5.19.0

Attachments
Bad colors on network manager (71.56 KB, image/png)
2020-03-02 22:01 UTC, Gabriel Fernandes 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Fernandes 2020-03-02 22:01:08 UTC 
Created attachment 126554 [details]
Bad colors on network manager

SUMMARY
Using Breeze colors (or Breeze Light) and Breeze Dark plasma style (plasma theme, theme of the panel) there's a part of the window that is themed incorrectly (they are based on the plasma style theme, I believe, instead of the colors). Please see attachment.


SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.18.2
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Jan Grulich 2020-03-03 12:15:18 UTC 
Git commit c9b2684a49d369dcfef95e0c26a64664138fc434 by Jan Grulich.
Committed on 03/03/2020 at 12:15.
Pushed by grulich into branch 'master'.

Use system color scheme from Kirigami instead of Plasma theme color

Summary: BUG: 418416

Reviewers: ngraham, #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidre, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27799

M  +7    -8    CMakeLists.txt
M  +4    -1    kcm/qml/main.qml

https://commits.kde.org/plasma-nm/c9b2684a49d369dcfef95e0c26a64664138fc434
Comment 2 Gabriel Fernandes 2020-03-03 13:12:55 UTC 
Hey, hello, I just tried the changes
I would like to make a suggestion
wouldn't it be better to use window background color instead of view background color?
Kirigami.Theme.colorSet: Kirigami.Theme.Window
instead of
Kirigami.Theme.colorSet: Kirigami.Theme.View

with window background color: https://imgur.com/a/mWBc2py
with view background color: https://imgur.com/a/RaPRglj
Comment 3 Jan Grulich 2020-03-03 13:16:31 UTC 
I was considering it, but I did it this way because the buttons are related to the view. On the other hand the button on the left side is not and it looks in some color variants nicer. I will leave this to VGD to decide.
Comment 4 Gabriel Fernandes 2020-03-03 13:44:08 UTC 
I just wanted to add that now, without the patch, if you use the same plasma style as the color scheme, the window looks exactly like this https://imgur.com/a/mWBc2py (with window background color)
Comment 5 Jan Grulich 2020-03-03 13:53:48 UTC 
Git commit 7de9e9cdbd57b991226fe7467fbca4841e73e9e0 by Jan Grulich.
Committed on 03/03/2020 at 13:53.
Pushed by grulich into branch 'master'.

KCM: restore original color

M  +1    -1    kcm/qml/main.qml

https://commits.kde.org/plasma-nm/7de9e9cdbd57b991226fe7467fbca4841e73e9e0
Comment 6 Nate Graham 2020-03-03 17:08:55 UTC 
IMO these commits should go on the stable branch too.
Comment 7 Jan Grulich 2020-03-04 05:28:51 UTC 
(In reply to Nate Graham from comment #6)
> IMO these commits should go on the stable branch too.

They cannot, because it introduces dependency on Kirigami, until now we required Kirigami only for the mobile KCM, which was optional.
Comment 8 Nate Graham 2020-03-04 05:35:08 UTC 
Ah ok!
Comment 9 Nicolas Fella 2020-03-11 21:29:24 UTC 
*** Bug 418740 has been marked as a duplicate of this bug. ***
Comment 10 Christoph Feck 2020-03-22 10:39:02 UTC 
*** Bug 419102 has been marked as a duplicate of this bug. ***