Bug 418345 - Desktop file lacks keywords and mimetypes
Summary: Desktop file lacks keywords and mimetypes
Status: RESOLVED WORKSFORME
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.3.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-01 01:30 UTC by Nathaniel Beaver
Modified: 2020-04-08 04:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for the desktop file. (1.34 KB, patch)
2020-03-01 01:30 UTC, Nathaniel Beaver
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nathaniel Beaver 2020-03-01 01:30:08 UTC
Created attachment 126509 [details]
Patch for the desktop file.

SUMMARY
Okular desktop file could be improved.

STEPS TO REPRODUCE
1. Open any menu search.
2. Search for "PDF".
3. Look for Okular.

OBSERVED RESULT
Okular does not show up in search results.

EXPECTED RESULT
Okular shows up in search results.

ADDITIONAL INFORMATION

I've attached a patch that adds the "keywords" and "tryexec" fields, as well as more mimetypes.

This is for the most recent version of "org.kde.okular.desktop" here:

https://cgit.kde.org/okular.git/tree/shell/org.kde.okular.desktop?id=341875b342d7ae5fdbf7fa411c1d11354983caa8

https://cgit.kde.org/okular.git/tree/shell/org.kde.okular.desktop
Comment 1 Albert Astals Cid 2020-03-01 09:00:13 UTC
No it doesn't there's other desktop files for each of the plugins you install since the installed plugins are what defines which different mimetypes you can or can not open, having okular instaled means nothing if you don't have any plugin installed
Comment 2 Nathaniel Beaver 2020-03-02 23:40:28 UTC
Ah, I see what you mean:

https://cgit.kde.org/okular.git/tree/generators/poppler/okularApplication_pdf.desktop?id=341875b342d7ae5fdbf7fa411c1d11354983caa8

Would you be interested in adding a "Keywords" field in addition to or instead of the "X-KDE-Keywords" field?

The "Keywords" field is what the application launcher is looking for.

https://cgit.kde.org/plasma-workspace.git/tree/runners/services/servicerunner.cpp?id=a1ea02d8e0bd1541e5d35969d6b4ba3b90f01c81#n137
Comment 3 Nathaniel Beaver 2020-03-03 00:19:16 UTC
Also, the "NoDisplay=true" would need to be removed.

https://cgit.kde.org/okular.git/tree/generators/poppler/okularApplication_pdf.desktop?id=341875b342d7ae5fdbf7fa411c1d11354983caa8#n219
Comment 4 Nathaniel Beaver 2020-03-03 00:21:13 UTC
Relevant link to your blog:

https://tsdgeos.blogspot.com/2014/11/keywords-vs-x-kde-keywords-on-desktop.html
Comment 5 Albert Astals Cid 2020-03-06 22:15:17 UTC
You're welcome to propose a Merge Request chaning x-keywords.

NoDisplay is not going to be removed, makes no sense
Comment 6 Nathaniel Beaver 2020-03-09 02:41:59 UTC
So you want org.kde.okular.desktop to have additional keywords, but not additional mimetypes? That's simple enough.

Otherwise I don't see how a menu search for "PDF" is going to surface Okular as a result.
Comment 7 Albert Astals Cid 2020-03-09 18:13:10 UTC
(In reply to Nathaniel Beaver from comment #6)
> So you want org.kde.okular.desktop to have additional keywords, but not
> additional mimetypes? That's simple enough.
> 
> Otherwise I don't see how a menu search for "PDF" is going to surface Okular
> as a result.

Ah no, i meant moving X-KDE-Keywords to Keywords

I understand that this is a problem, but needs a solution that is not the okular.kdestop file lying about the things it supports
Comment 8 Bug Janitor Service 2020-03-24 04:33:13 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2020-04-08 04:33:15 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!