Bug 418318 - The hover state should be clarifying, but not main
Summary: The hover state should be clarifying, but not main
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.18.1
Platform: Other Linux
: LO normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-29 10:24 UTC by popov895
Modified: 2020-03-27 04:10 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
States from left to right: minimized, hovered minimized, normal, hovered normal, active, hovered active (29.74 KB, image/png)
2020-02-29 10:24 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-02-29 10:24:06 UTC
Created attachment 126492 [details]
States from left to right: minimized, hovered minimized, normal, hovered normal, active, hovered active

SUMMARY

I'm trying to make a custom appearance of the taskbar by creating a new theme, but I ran into some issue. As you can see from the attachment, I expected that there are three main states (minimized, normal and active) and one clarifying state (hover). But when I started editing widgets/tasks.svgz, I was surprised to find that there are four main states (minimized, normal, active and hover), and the hover state is also main, but not clarifying. I believe that the hover state should be clarifying for the main states, i.e. there must be three main states (minimized, normal and active) and three additional (minimzed-hover, normal-hover, active-hover).

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE Neon 5.18
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 David Edmundson 2020-03-04 20:50:19 UTC
Moving back as it requires no changes in Breeze, only task manager.

I don't disagree with your original premise. Yes it should be a flag.

It gets quite convoluted as it would be a theme break - and hover itself is already optional.

I believe it means we would have to set the SVG prefix to be (in order):

[west-hover-normal, hover-normal, west-hover, hover, west-normal, normal]

is that correct?
Comment 2 David Edmundson 2020-03-04 20:57:41 UTC
Something like

https://phabricator.kde.org/P555

^ as I had the code open to reply. 


Realistically I don't care for 3rd party themes, so if you want this change you have to reply to the above ordering, and then do something useful with the patch.
Comment 3 popov895 2020-03-05 13:41:27 UTC
Yes, it's a pretty good solution. I tested it and it allows me to solve the specified problem, and also it doesn't break the current themes (at least breeze theme works fine). But I'd prefer to use SVG suffix instead of prefix:

[west-normal-hover, normal-hover, west-hover, hover, west-normal, normal]
Comment 4 Bug Janitor Service 2020-03-20 04:33:12 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 popov895 2020-03-20 08:15:07 UTC
What do you mean by saying "do something useful with the patch"? Do I need to submit the patch myself?
Comment 6 Nate Graham 2020-03-23 20:28:10 UTC
Yes, feel free to take that code and submit it on https://phabricator.kde.org/differential/diff/create/, with any modifications you find necessary.
Comment 7 popov895 2020-03-24 17:07:11 UTC
I have strange behaviour of the task manager after some manipulations with the /usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml. Before that, I tested the patch from Comment 2 on a virtual machine and everything worked fine. But now I have started testing it on a real machine, and after applying this patch and rebooting, I noticed that the task manager stopped displaying the minimized state. Then I restored the original file and rebooted, but the task manager still didn't display the minimized state. Having decided that the problem is with the QML cache, I cleared the ~/.cache folder and rebooted, but this also didn't solve my problem. So, the task manager still doesn't display minimized state. Any ideas?
Comment 8 popov895 2020-03-25 15:52:48 UTC
Found the reason for this behavior and filled a bug 419236
Comment 9 popov895 2020-03-26 11:58:29 UTC
https://phabricator.kde.org/D28306
Comment 10 Nate Graham 2020-03-27 04:10:16 UTC
Git commit 488c4b746d68e07a44e538e8507229577a2c1bf8 by Nate Graham, on behalf of Eugene Popov.
Committed on 27/03/2020 at 04:10.
Pushed by ngraham into branch 'master'.

[applets/taskmanager] Make the hover state clarifying, but not main

Summary:
I'm trying to make a custom appearance of the Task Manager by creating a new theme, but I ran into some issue. I expected that there are three main states (minimized, normal and active) and one clarifying state (hover). But I was surprised to find that there are four main states (minimized, normal, active and hover), and the hover state is also main, but not clarifying. I believe that the hover state should be clarifying for the main states, i.e. there must be three main states (minimized, normal and active) and three additional (minimzed-hover, normal-hover, active-hover).

See https://phabricator.kde.org/P555

Reviewers: davidedmundson, #vdg

Reviewed By: davidedmundson

Subscribers: broulik, ngraham, epopov, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28306

M  +2    -10   applets/taskmanager/package/contents/ui/Task.qml
M  +13   -0    applets/taskmanager/package/contents/ui/code/tools.js

https://commits.kde.org/plasma-desktop/488c4b746d68e07a44e538e8507229577a2c1bf8