Created attachment 126467 [details] folderview config iconmode SUMMARY When using folderview plasmoid on a panel, the config dialog shows a selection of icon mode or list mode. In list mode, the size of icons disappear, but that is wrong since the size is used in list mode. Example: select icon mode and set size to minimal, apply, then change back to list mode and apply. list mode will use minimum size icons. If changing back to icon mode and using maximum size, apply, then change back to list mode, the icons will be huge. I don't think there is anything wrong with selecting the size of icons in listmode. If i am not in error, it seems to be this code: plasmoids/org.kde.desktopcontainment/contents/ui -> line 229 with: visible: !isPopup || viewMode.currentIndex === 1 Thanks ! STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Created attachment 126468 [details] folderview config listmode
Yes, that's the code used to prevent the size from being selectable in list mode. I also don't see the problem here. Feel free to submit a patch to change that! I can help you if you get stuck. Here's the documentation: https://community.kde.org/Infrastructure/Phabricator
> I also don't see the problem here. The issue is that the selector of icon size also changes the icon size on list mode. So, either one of two solutions: * let icon size slider be visible while on list mode * select a specific size for list mode that cannot be changed Please tell me you understand the problem, so that I don't propose or change anything that kde devs don't want ! > Feel free to submit a patch to change that! Would love to do that and start contributing in code. May I do it on the weekend ? I already have a kdebuild-src environment working, just need to learn how to start doing this in terms of kde work structure!
I understand the problem, and I confused you with my inaccurate response, sorry. Either of those solutions is fine, but I would lean towards allowing the size to be configurable in list view. Go right ahead and submit the patch whenever you like, there's no rush. :)
Git commit 1d557e8a78a737b6c63bf2400e863738f1f063ff by Nate Graham, on behalf of Alexandre Pereira. Committed on 05/05/2020 at 18:46. Pushed by ngraham into branch 'master'. Fix folderview popup mode list view icon size inheriting icon view icon size Summary: The icon size is only selectable in icon view mode. but selecting a different icon size on icon view mode also changes the size of the icons in list view mode. This creates a problem since the list icon size is hardcoded by default to small, but it seems it is being changed on other places of the code. FIXED-IN: 5.19.0 Test Plan: I tested this on icon folderview and normal desktop folderview, changing icon sizes in iconview and listview and restarting plasmashell. Reviewers: #plasma, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28057 M +8 -0 containments/desktop/package/contents/ui/FolderView.qml https://commits.kde.org/plasma-desktop/1d557e8a78a737b6c63bf2400e863738f1f063ff