Bug 418204 - Menu entries to lock the toolbar and panel positions have an inconsistent user interface
Summary: Menu entries to lock the toolbar and panel positions have an inconsistent use...
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 18.12.3
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-25 22:16 UTC by smokythebearonthemountain
Modified: 2020-02-28 12:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description smokythebearonthemountain 2020-02-25 22:16:27 UTC
SUMMARY

The context menu entries to lock the toolbar and panels have an inconsistent user interface. 

The toolbar context menu entry to lock the toolbar position uses fixed text ('Lock Toolbar Positions') and a padlock icon that is always displayed in the locked state. The lock state of the toolbar is shown using a checkbox adjacent to the menu option.

In contrast, the context menu entry to lock the panels does not use a checkbox and instead changes the text and icon of the menu entry itself to reflect the locked state of the panels.

I am aware this is a pedantic nitpick and not a functionality issue, but interface consistency would make Dolphin look more polished.

STEPS TO REPRODUCE
1. 

Use the toolbar context menu to lock and unlock the toolbar. Note the behavior of the 'Lock Toolbar Positions' menu entry.

2. 

Use the panel context menu to lock and unlock the panel. Note the behavior of the 'Lock Panels' / 'Unlock Panels' menu entry.

3. 

Note the differences in behaviors between the two components.

OBSERVED RESULT

The context menu entries to lock the toolbar and panels have an inconsistent user interface. 

EXPECTED RESULT

The locking commands should have consistent behavior matching the most common practice among other KDE applications.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: OpenSUSE LEAP 15.1 / KDE Plasma 5.12.8
(available in About System)
KDE Plasma Version: 5.12.8
KDE Frameworks Version: 5.55.0
Qt Version: 5.9.7

ADDITIONAL INFORMATION

None.
Comment 1 Nate Graham 2020-02-25 23:23:51 UTC
Yeah,  te should use a toggle action everywhere rather than changing the name of the menu item.