Bug 418165 - In color scheme editor buttons have low-res images with fractional scaling
Summary: In color scheme editor buttons have low-res images with fractional scaling
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.18.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2020-02-25 10:55 UTC by Matej Mrenica
Modified: 2020-05-06 14:21 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (10.01 KB, image/png)
2020-02-25 10:58 UTC, Matej Mrenica
Details
Plasma 5.18.3, display scale 125% (10.54 KB, image/png)
2020-03-13 21:36 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-02-25 10:55:43 UTC
This might be a part of a bigger issue. Screen resolution is FHD with 1.25 scaling.
Comment 1 Matej Mrenica 2020-02-25 10:58:31 UTC
Created attachment 126397 [details]
Screenshot
Comment 2 Kai Uwe Broulik 2020-02-25 11:00:41 UTC
KColorSchemeEditor probably just lacks UseHighDpiPixmaps flag
Comment 3 Matej Mrenica 2020-02-25 11:17:04 UTC
Also affects icons in titlebar appmenu of any app.
Comment 4 Matej Mrenica 2020-02-28 20:33:20 UTC
As there seems to be more and more locations with this issue, I propose creating a phabricator task with a list of every place where this issue is present. I am willing to do it if you agree, I am even willing to work on a fix, if you tell me how to do it.
Comment 5 David Edmundson 2020-02-28 22:51:59 UTC
>I propose creating a phabricator task with a list of every place where this issue is present.

If you like.

>I am even willing to work on a fix, if you tell me how to do it.

As you noted, it's not one fix it's many.

In general you have to learn the difference between logical pixels and device pixels and applied that through any custom painting code. 

We also need to turn on a flag at a per-application basis to opt-in for high DPI. This task is 99% about testing rather than actually adding the line, as when turned on the application can break (or potentially even crash) horribly, any custom painting needs checking.
Comment 6 Matej Mrenica 2020-02-29 10:19:56 UTC
It looks like this issue is present in every title-bar appmenu of every app, does this mean the issue is located in every app or only in the appmenu code.
Comment 7 Patrick Silva 2020-03-13 21:36:03 UTC
Created attachment 126771 [details]
Plasma 5.18.3, display scale 125%

cannot reproduce on my system

Operating System: Arch Linux 
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 8 Nate Graham 2020-05-06 14:21:42 UTC
Git commit 2c46f28170c785f04fa396803037a608c8077025 by Nate Graham, on behalf of Matej Mrenica.
Committed on 06/05/2020 at 14:21.
Pushed by ngraham into branch 'Plasma/5.18'.

Fix blurry icons in KColorSchemeEditor

Summary:
When using fractional scaling, bottom icons are blurred. This patch fixes the issue.

Test Plan:
No side effects.

Before:
{F8289358}
After:
{F8289369}

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29481

M  +2    -0    kcms/colors/editor/kcolorschemeeditor.cpp

https://commits.kde.org/plasma-desktop/2c46f28170c785f04fa396803037a608c8077025