Bug 418100 - Wrong task shade for minimized/visible applications
Summary: Wrong task shade for minimized/visible applications
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.18.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: regression
: 418252 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-23 16:45 UTC by magiblot
Modified: 2020-02-27 16:03 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
In the task manager, visible application is grayed out as if it was minimized. Minimized task looks as if it was visible. (1.16 MB, image/png)
2020-02-23 16:45 UTC, magiblot
Details
Original behaviour in Plasma 5.17.4 (187.83 KB, image/png)
2020-02-23 16:47 UTC, magiblot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description magiblot 2020-02-23 16:45:50 UTC
Created attachment 126345 [details]
In the task manager, visible application is grayed out as if it was minimized. Minimized task looks as if it was visible.

SUMMARY

In Plasma 5.18, minimized tasks in the Task Manager are shaded as if they were visible. Conversely, visible tasks are shaded as if they were minimized.

If I don't recall wrong, I began noticing this issue after upgrading to Plasma 5.18 from a previous version.

SOFTWARE/OS VERSIONS

Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Kernel Version: 5.5.5-arch1-1
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz
Memory: 11,6 GiB of RAM
Comment 1 magiblot 2020-02-23 16:47:02 UTC
Created attachment 126346 [details]
Original behaviour in Plasma 5.17.4
Comment 2 Michael D 2020-02-23 17:22:07 UTC
I agree the "shading" looks wrong. Non-minimized windows looks minimized. For purposes of readability, I do not think there should be *any* shading since that maximizes font and background contrast.

If you look at the two images I link to, the one without shading is more readable and, to my eye at least, looks better: https://imgur.com/a/1nTR1BK.
Comment 3 Michael D 2020-02-23 17:28:31 UTC
By the way, is this an issue with the Breeze plasma theme rather than the task manager widget? It also affects the icon-only task manager widget.
Comment 4 Nate Graham 2020-02-24 05:34:52 UTC
It's an issue with the Breeze Plasma theme, yeah.

This was an intentional change, done in https://commits.kde.org/plasma-framework/7e52c869de2d58ff714b60252041a447db2c10c0, to fix Bug 370465.

It looks like users of Icons-Only Task Managers don't mind this change; we haven't gotten any bug reports or complaints. But users of Traditional Task Managers have grumbled a bit.

I'm not sure it should be reverted entirely; just look at the number of duplicates on the bug that was fixed by the change! But maybe we should brainstorm a way to make the change just for the IOTM, and use the old style for the TTM .

Not sure how we could easily fix it since the TTM and IOTM both use the same SVGs, yet it looks like that set of SVGs always works better for one widget than the other.
Comment 5 Michael D 2020-02-24 08:20:20 UTC
The IOTM looks equally bad but is less noticeable because it spans less of the panel. In my opinion, both IOTM and TTM should receive the same fix.
Comment 6 Nate Graham 2020-02-24 13:44:40 UTC
(In reply to Michael D from comment #5)
> The IOTM looks equally bad but is less noticeable because it spans less of
> the panel. In my opinion, both IOTM and TTM should receive the same fix.
I don't agree with regards to the IOTM. The previous style made it more difficult to tell when an app was open vs when it was closed. Again, see the number of duplicates on Bug 370465. Clearly a lot of people didn't like the previous style.

Sometimes a visual change is something that just needs a bit of getting used to. :)
Comment 7 Michael D 2020-02-24 14:21:19 UTC
Hmm, I see the problem with the IOTM if you pin apps, which I don't. That problem doesn't arise with the TTM because pinned apps are only icons, hence easily distinguishable from running apps. So seems reasonable to treat them differently.

But I hope the TTM is changed because right now it's an eyesore, especially depending on what color scheme one uses.
Comment 8 Nate Graham 2020-02-25 21:10:04 UTC
We discussed this in the VDG room a bunch and came to the conclusion that we'd like to let things simmer a while longer before we rush to change anything. We implemented this change to fix a bug that was causing a lot of people a lot of pain, and we couldn't find a clean way to fix it just for them without changing anything for anyone else.

So let's close this for now, but collect duplicate reports anyway to see how many people get annoyed. :)
Comment 9 Michael D 2020-02-27 13:36:31 UTC
That's a shame, but I understand of course. Here's hoping there's a lot of duplicate reports :)
Comment 10 Nate Graham 2020-02-27 16:03:58 UTC
*** Bug 418252 has been marked as a duplicate of this bug. ***