Bug 418082 - Spinner rotates all the time after search and makes Discover slower on Wayland
Summary: Spinner rotates all the time after search and makes Discover slower on Wayland
Status: RESOLVED WORKSFORME
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-23 10:12 UTC by Patrick Silva
Modified: 2021-05-07 04:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
screenshot (63.65 KB, image/png)
2020-02-23 10:13 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-02-23 10:12:41 UTC
STEPS TO REPRODUCE
1. open Discover on Wayland and search for some app
2. 
3. 

OBSERVED RESULT
spinner rotates all the time below search results, see the attached screenshot.
While the spinner rotates, Discover is slower, with delay to show hover effects and
open the description page of any search result, scrolling in description page is slow.

EXPECTED RESULT
spiinner should stop immediately when search is completed.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-23 10:13:26 UTC
Created attachment 126329 [details]
screenshot
Comment 2 Bug Janitor Service 2020-12-02 03:26:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/56
Comment 3 Aleix Pol 2020-12-02 13:55:00 UTC
Git commit 336ea21a95549321dbee7d9d84e3a24033ec1394 by Aleix Pol.
Committed on 02/12/2020 at 03:28.
Pushed by apol into branch 'master'.

When we call to check for updates, we expect updates

This changes it so when there's nothing installed we notify about no
updates being found.

M  +4    -0    src/attica/atticaprovider.cpp

https://invent.kde.org/frameworks/knewstuff/commit/336ea21a95549321dbee7d9d84e3a24033ec1394
Comment 4 Aleix Pol 2020-12-02 13:56:16 UTC
Git commit 7a4215b7b477de02103af6062b11819fb0c912d2 by Aleix Pol.
Committed on 02/12/2020 at 03:24.
Pushed by apol into branch 'master'.

kns: Restore the state of the stream after checking for updates

Otherwise they stay lingering forever giving the impression that it's
stuck.

M  +4    -0    libdiscover/backends/KNSBackend/KNSBackend.cpp

https://invent.kde.org/plasma/discover/commit/7a4215b7b477de02103af6062b11819fb0c912d2
Comment 5 Patrick Silva 2020-12-09 11:09:11 UTC
This bug is still reproducible.

1. search for Event Calendar plasma addon
2. click on "event calendar" search result to open its description page
3. search for an app, let's say Audacity
4. scroll down the search results and you will see a spinner that never stops

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Comment 6 Aleix Pol 2021-01-14 18:53:04 UTC
I could reproduce.
Comment 7 Nate Graham 2021-04-07 22:11:19 UTC
Works for me on Wayland with current git master. Can you reproduce?
Comment 8 Bug Janitor Service 2021-04-22 04:33:17 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2021-05-07 04:33:36 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!