Created attachment 126290 [details] screenshot STEPS TO REPRODUCE 1. open a ghns window 2. change view by clicking on the first icon beside the search field on top 3. install any addon OBSERVED RESULT "Details..." button overlaps "installing" effect during installation EXPECTED RESULT "Details..." button should remain hidden until installation is completed SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.1 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/18
Git commit 36665de5091ae456e97615bdfa9519c0b57d3cc9 by Nate Graham, on behalf of Alexander Lohnau. Committed on 23/07/2020 at 17:03. Pushed by ngraham into branch 'master'. Fix display of Details and Uninstall button in Tiles view mode FIXED-IN: 5.73 M +2 -1 src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml https://invent.kde.org/frameworks/knewstuff/commit/36665de5091ae456e97615bdfa9519c0b57d3cc9
still reproducible on neon unstable. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.73.0 Qt Version: 5.14.2
no longer reproducible on neon unstable.
still reproducible on both Arch and neon unstable. 1. open system settings > Colors 2. click on "Get new color schemes..." button 3. set tiles view mode 4. hover over any non installed color scheme, click on "Install" button and do NOT move cursor Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.74.0 Qt Version: 5.14.2
Well this is kindof intentional. If you install a plugin you still want to be able to go into the details view, maybe to compare different themes or whatever. Especially if the installation takes a bit longer this seems like a valid usecase. And in the bugfix we ensured that the button only gets shown on hover. And if we don't move the cursor we are still hovering. So we could just say that these buttons should be hidden when we are installing/updating an entry(you could still view the details by clicking on the entry itself), but that would make the UI inconsistent. Nate, Dan any thoughts?
We are already able to go into the details when using any of the 3 view modes available by clicking on the entry itself during install process, so maybe "Details..." button is unnecessary. Currently tiles view is the only one that shows "Details..." button when we hover over an addon being installed.
>so maybe "Details..." button is unnecessary Hmm, that makes sense. Nate, Dan what do you think about this?
I agree. It's obvious enough that clicking on the entry will let you see its details.
i can't help worry about the discoverability of it, but sure, i'm basically fine with getting rid of the [Details...] buttons if people have particularly strong feelings about it.
To clarify, what I meant is that maybe "Details..." button is unnecessary during install/update process. But if you prefer to remove it completely I have no objection.
>i can't help worry about the discoverability of it In the other view modes the details button does not exist, so we would make it consistent.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/33
Git commit b1d8f1788b25a82f00776c2f9e45ba9c7bd30978 by Alexander Lohnau. Committed on 14/08/2020 at 15:18. Pushed by alex into branch 'master'. Remove details button Related: bug 424895 FIXED-IN: 5.74 M +0 -6 src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml https://invent.kde.org/frameworks/knewstuff/commit/b1d8f1788b25a82f00776c2f9e45ba9c7bd30978