Bug 417848 - Make applet activate Night Color when it's currently inactive
Summary: Make applet activate Night Color when it's currently inactive
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Night Color Control (show other bugs)
Version: 5.18.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-02-18 22:47 UTC by Mark Smith
Modified: 2022-12-30 04:46 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Smith 2020-02-18 22:47:18 UTC
SUMMARY
The system tray icon for night color control behaves in an odd way. Just look at the video.

STEPS TO REPRODUCE
1. Go to system settings and disable Night Color
2. Close the system settings
3. Go to the system tray
4. Click on the night color control icon
5. It will display Night Color On \ Off but night color does not actually enable
8. Go to system settings again
8. Enable Night Color
9. Night color will now enable and the system tray icon works again

Also, when clicking on the system tray, it opens as if it would allow additional configurations. Doesn't seem intended.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Neon 5.18 user edition
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.13.2

ADDITIONAL INFORMATION
Comment 1 Mark Smith 2020-02-18 23:31:56 UTC
Actually I think I figured it out. The tray icon (and also the shortcut if you set a global shortcut) is no longer synced with whatever you set in the system settings. In 5.17 the keyboard shortcut (because there was no tray icon) would enable or disable night color from the settings. Now, if night color is disabled in system settings, the tray icon and shortcut will no longer work. 

I wanted manual control of night color, so in 5.17 IIRC I set it to always enabled and then controlled it with the keyboard shortcut. This is annoying in 5.18 because if I set it to always on, when I turn on my computer night color will be on no matter if it was set off with the keyboard shortcut or tray icon before. 

So, assuming this behavior is intended, an option called "manual control" or something should be added, and the last manually set status should be remembered after a reboot.
Comment 2 Bug Janitor Service 2022-12-24 03:43:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/302
Comment 3 Nate Graham 2022-12-30 04:46:01 UTC
Git commit a71932a33f4a06be7e8b71d10ebf65b4f7c579a7 by Nate Graham, on behalf of Guilherme Marçal Silva.
Committed on 30/12/2022 at 04:43.
Pushed by ngraham into branch 'master'.

Open settings if user clicks on applet but Night Color is set to Always off

M  +3    -3    applets/nightcolor/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/a71932a33f4a06be7e8b71d10ebf65b4f7c579a7