Bug 417776 - Icon for Minimize all Windows and Show Desktop widgets should not always be monochrome/symbolic when in a panel
Summary: Icon for Minimize all Windows and Show Desktop widgets should not always be m...
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.18.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-17 08:42 UTC by Sadi
Modified: 2020-02-19 11:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sadi 2020-02-17 08:42:20 UTC
SUMMARY
Sorry if this bug report is misplaced, but I couldn't find a category.
I use either of these widgets in a Unity-style desktop layout provided by Latte Dock where I have a left panel/dock including my favorite apps with Application Dashboard widget at the top and Latte Tasks,Show Desktop widget, flexible space and trashcan widget at the bottom.
Now, if a symbolic icon used by Minimize all Windows and Show Desktop widgets looks very out of place here, and unfortunately there's no option to choose any other icon (as some widgets offer).

STEPS TO REPRODUCE
1. Start Latte Dock
2. Select Unity from Layouts
3. Add Minimize all Windows or Show Desktop widget

OBSERVED RESULT
Unlike app launchers and most other widgets added to the left panel/dock, these widgets display a symbolized icon.

EXPECTED RESULT
It seems the best solution might be adding a feature for the users to choose icon for this widget - considering that some users might use this widget in a (Unity-style left or Mac-style bottom) dock while others might use it in a bottom or top panel (where it's probably more appropriate to display a symbolic icon)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-02-17 19:56:56 UTC
We've been asked numerous times by a large number of users to use only symbolic icons for widgets on panels. Previously, the style of the icon (symbolic vs colorful) was determined with the panel thickness, but we got many many complaints about this, so we are now moving towards the current always-symbolic style.

If this bugs you, you can always edit /usr/share/plasma/desktoptheme/default/icons/user.svgz and remove the unwanted icons from it, which will make itt fall back to using colorful icons for larger sizes.
Comment 2 Sadi 2020-02-18 08:30:33 UTC
(In reply to Nate Graham from comment #1)
> We've been asked numerous times by a large number of users to use only
> symbolic icons for widgets on panels. Previously, the style of the icon
> (symbolic vs colorful) was determined with the panel thickness, but we got
> many many complaints about this, so we are now moving towards the current
> always-symbolic style.

I fully understand that widget icons should always be monochrome/symbolic in the panel irrespective of panel thickness.

I think maybe a better solution could be achieved - if possible - if this can be made conditional - i.e. if it is a dock and not a panel, then a colorful icon from the current icon theme should be used instead like the app launchers in that dock (for instance, as I use Latte Dock in Unity layout, I can see that I have a top "panel" and a left "dock"; and some users may have a Mac-style bottom dock as well).

So maybe you can consider this as a feature request for further improvement of the excellent looks and appearance of KDE.

> If this bugs you, you can always edit
> /usr/share/plasma/desktoptheme/default/icons/user.svgz and remove the
> unwanted icons from it, which will make itt fall back to using colorful
> icons for larger sizes.

Thank you very much for the tip.
Comment 3 Sadi 2020-02-18 12:19:19 UTC
(In reply to Nate Graham from comment #1)

> If this bugs you, you can always edit
> /usr/share/plasma/desktoptheme/default/icons/user.svgz and remove the
> unwanted icons from it, which will make itt fall back to using colorful
> icons for larger sizes.

I'd like to add that editing "user.svgz" and removing the larger (64px and 48px) user-desktop icons from it *almost* achieved the desired result. But I saw consistently blank space until I hovered on it to display the standard color user-desktop icon, which I could overcome only by removing the file "user.svgz" altogether. That's fine for me as a workaround, but I think perfect solution would be as I've suggested above.
Comment 4 Nate Graham 2020-02-18 16:34:40 UTC
(In reply to Sadi from comment #2)
> I fully understand that widget icons should always be monochrome/symbolic in
> the panel irrespective of panel thickness.
> 
> I think maybe a better solution could be achieved - if possible - if this
> can be made conditional - i.e. if it is a dock and not a panel, then a
> colorful icon from the current icon theme should be used instead like the
> app launchers in that dock (for instance, as I use Latte Dock in Unity
> layout, I can see that I have a top "panel" and a left "dock"; and some
> users may have a Mac-style bottom dock as well).
Unfortunately there is no way for a Panel to know if it's being used as a dock, a taskbar, a global menubar, a pull-out widget drawer, or whatever. It is just a generic container for holding widgets. In the past, we roughly approximated what you wanted by having things change their visual style according to thickness, on the logic that taskbars and global menubars would be on thin panels and their users would want everything monochrome, and docks would be on thick panels and their users would prefer colorful icons. But in practice it didn't seem to work out and we kept getting bug reports about the icons changing style based on panel thickness and now people thought it was weird.

I actually agree with you that with a thick macOS/Unity style dock, it is nicer to have colorful large widget icons. However this is also kind of inconsistent since the system tray icons will always be monochrome. We wrestled with this conundrum and in the end settled on the current imperfect solution of just always using monochrome icons no matter the thickness.

(In reply to Sadi from comment #3)
> I'd like to add that editing "user.svgz" and removing the larger (64px and
> 48px) user-desktop icons from it *almost* achieved the desired result. But I
> saw consistently blank space until I hovered on it to display the standard
> color user-desktop icon, which I could overcome only by removing the file
> "user.svgz" altogether. That's fine for me as a workaround, but I think
> perfect solution would be as I've suggested above.
You may need to delete ~/.cache/plasma* afterwards.
Comment 5 Sadi 2020-02-19 11:46:14 UTC
(In reply to Nate Graham from comment #4)

> Unfortunately there is no way for a Panel to know if it's being used as a
> dock, a taskbar, a global menubar, a pull-out widget drawer, or whatever.
In that case, there's no other way, I agree. But I thought that it was possible to distinguish between "panel" and "dock" because when I right-click the one on the left Latte context menu shows "Dock Settings..." at the bottom, and "Panel Settings..." for the one on the top.
 
> I actually agree with you that with a thick macOS/Unity style dock, it is
> nicer to have colorful large widget icons. However this is also kind of
> inconsistent since the system tray icons will always be monochrome.
In that case users should only use system tray in the "panel" and not in the "dock".

> You may need to delete ~/.cache/plasma* afterwards.
I've already solved this by removing "user.svgz", but out of curiousity I also tried deleting cache and using "user.svgz" with only 64px and 48px user-desktop images removed: it didn't make any difference - actually even replacing them  with color 64px and 48px user-desktop images instead of just leaving blank didn't prevent showing a blank area initially. Anyway no problem for me anymore. Thanks.