Bug 417710 - Odd spacing for "Wifi" and "Airplane mode" toggles
Summary: Odd spacing for "Wifi" and "Airplane mode" toggles
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-15 15:04 UTC by Alexander Ewering
Modified: 2024-12-23 18:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (21.39 KB, image/png)
2020-02-15 15:04 UTC, Alexander Ewering
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Ewering 2020-02-15 15:04:58 UTC
Created attachment 126062 [details]
Screenshot

Sorry if this is the wrong component, I wasn't sure which is the correct one.

The spacing for the "Wifi" and "Airplane mode" toggles and their respective checkboxes and icons is really odd. i.e., the space between the two toggles is much smaller than the space between each corresponding checkbox and its icon, making the whole interface very visually confusing.
Comment 1 Nate Graham 2020-02-17 00:11:30 UTC
Confirmed. George, do any of your open patches fix this already?
Comment 2 gvgeo 2020-02-17 15:30:23 UTC
https://phabricator.kde.org/D27453
Comment 3 Alexander Ewering 2020-02-17 15:57:23 UTC
New one looks perfect, that was quick! And sorry for the UI nitpicking.
Comment 4 Nate Graham 2020-02-18 04:42:09 UTC
Git commit 88b8ce5e50b75daf025eb3e59cf1726cd74ba2d9 by Nate Graham, on behalf of George Vogiatzis.
Committed on 18/02/2020 at 04:42.
Pushed by ngraham into branch 'master'.

[Applet]Update toolbar's checkbox spacing

Summary:
Move the switchButton's icon smallSpacing left.
Make icon size smallMedium.

Test Plan:
Before:
{F8108357, size =full}
After:
{F8108335, size =full}

Reviewers: #plasma, #vdg, jgrulich, ngraham

Reviewed By: #vdg, jgrulich, ngraham

Subscribers: broulik, plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D27453

M  +7    -9    applet/contents/ui/SwitchButton.qml

https://commits.kde.org/plasma-nm/88b8ce5e50b75daf025eb3e59cf1726cd74ba2d9
Comment 5 Ben Cooksley 2024-12-23 18:26:06 UTC
Bulk transfer as requested in T17796