Bug 417709 - Copy/clone common metadata (rating, location, tags, ...) when creating panorama image
Summary: Copy/clone common metadata (rating, location, tags, ...) when creating panora...
Status: REPORTED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-Panorama (show other bugs)
Version: 8.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-15 14:17 UTC by Jens
Modified: 2024-09-14 10:53 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2020-02-15 14:17:17 UTC
SUMMARY
see $subject

STEPS TO REPRODUCE
1. create panorama from multiple images
2. note the resulting image has a lot of missing metadata

EXPECTED RESULT
I would expect the resulting image to have at least the metadata (EXIF and Digikam style) that is common between all images to be copied. This includes EXIF data like camera and lens, flash, but also location, rating and tags.

If the metadata is not the same between all images, Digikam should offer to copy the metadata from the first source image.
Comment 1 Maik Qualmann 2020-02-15 19:10:53 UTC
The EXIF metadata are explicite not adopted. Camera make and model only. In principle, the information no longer matches the newly created panorama. If we were to apply the lens information and other metadata, applying lens correction would result in malfunction. I can understand that one would like to know later with which exposure settings the image were taken. In practice, the metadata is no longer correct and can cause problems.

Maik
Comment 2 Jens 2020-02-15 20:10:48 UTC
This is Ok for technical data. But if all panorama parts have three stars, a geo tag and a set of normal tags, I would expect the panorama result to have this metadata too.
Comment 3 Maik Qualmann 2020-02-15 20:52:59 UTC
The metadata like tags, rating must be in the images. It works well for JPEG files, for RAW files the Panorama Toot currently ignores the sidecar files. Because of the historical development, the panorama tool is not currently using the DB.

Maik
Comment 4 Maik Qualmann 2020-02-15 23:10:18 UTC
Git commit 97d2aef3fe7e56ee9bb82836d0d0d10c04e01e16 by Maik Qualmann.
Committed on 15/02/2020 at 23:08.
Pushed by mqualmann into branch 'master'.

fix read metadata from RAW images with sidecars

M  +2    -2    core/dplugins/generic/tools/panorama/tasks/copyfilestask.h

https://invent.kde.org/kde/digikam/commit/97d2aef3fe7e56ee9bb82836d0d0d10c04e01e16
Comment 5 Jens 2020-02-17 16:07:17 UTC
I would not expect the panorama tool (or any other tool) to care about the sidecar files or the Digikam DB. If such a tool is integrated into Digikam, I would expect Digikam to care about metadata after the resulting image has been imported.

Ideally, with a dialog similar to the "overwrite" dialog in file managers saying "The new image can copy tags, rating, etc. from any of the input images. Which image should we use as the source?", a choice of Image 1, 2, ..., N, and "None",  and a "[x] Remember this choice" checkbox.
Comment 6 caulier.gilles 2020-08-01 08:11:56 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Thanks in advance

Gilles Caulier
Comment 7 Jens 2020-08-02 20:34:28 UTC
Still valid.
Comment 8 caulier.gilles 2023-04-29 19:32:45 UTC
@Jens,

digiKam 8.0.0 is out. This entry still valid with this release ?

Best regards

Gilles Caulier
Comment 9 Jens 2023-04-30 09:00:40 UTC
Still valid with 8.1.0-git appimage.
Comment 10 caulier.gilles 2023-04-30 09:38:17 UTC
Well, the solution of this problem can be simple and the current implementation cannot cover all use cases.

Here, there are few code to back-port metadata from the first file used to render the pano :

https://invent.kde.org/graphics/digikam/-/blob/master/core/dplugins/generic/tools/panorama/tasks/copyfilestask.cpp#L101

The code is not too bad but it's based of file metadata, not the digiKam properties. If the application do not play with the file metadata, the properties will be partially transfered.

Using DInfoInterface instead will work in all cases to restore all metadata, from the database or file metadata.

Gilles
Comment 11 caulier.gilles 2023-10-11 14:52:50 UTC
Maik,

As a reminder, note that to fix this issue is very simple as i pointed which code must be patch in comment #10.

Gilles