Bug 417608 - Option to remove configure button on knote widget.
Summary: Option to remove configure button on knote widget.
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: notes (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-14 03:57 UTC by Dashon
Modified: 2020-02-24 15:03 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
Example of the configure button being visible on the desktop when widget not being edited. (363.82 KB, image/png)
2020-02-14 03:57 UTC, Dashon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dashon 2020-02-14 03:57:12 UTC
Created attachment 126000 [details]
Example of the configure button being visible on the desktop when widget not being edited.

SUMMARY
Having the configure button visible at all times is not the best visually speaking. I was just wondering if it was possible to make this go away on the note itself. We still have access to it when editing the widget itself.

STEPS TO REPRODUCE
1. Add knote to desktop.
2. Leave it there.
3. Configure button always visible.

OBSERVED RESULT
Configure button always visible in lower corner of note.

EXPECTED RESULT
Configure button disappear once note is configured to color of choice.

SOFTWARE/OS VERSIONS
Fedora Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.66
Qt Version: 5.13.2

ADDITIONAL INFORMATION
On the image I include. It does look noticeably worse since I'm using a transparent note. This gives the configure button  the appearance of floating off onto the desktop by itself.
Comment 1 Laurent Montel 2020-02-14 06:04:32 UTC
it's not knotes but note plasma.
Please reassign to correct component.
Comment 2 Dashon 2020-02-14 06:10:51 UTC
(In reply to Laurent Montel from comment #1)
> it's not knotes but note plasma.
> Please reassign to correct component.

Will do but I don't see an option for note plasma in the products section.
Comment 3 Dashon 2020-02-14 06:15:54 UTC
(In reply to Laurent Montel from comment #1)
> it's not knotes but note plasma.
> Please reassign to correct component.

I've looked for note plasma and plasma note. Nothing else seems related in your product listing. Perhaps it goes under a new name?
Comment 4 David Edmundson 2020-02-14 08:30:12 UTC
I'm not adding an option. That's pointless feature overload.

The rationale for this being on the applet was that editing the notes background was a more common action that is more akin to editing note contents than editing how the note widget behaves so it's elevated in the UI.

Either this button:
 - makes sense and should stay
 - doesn't make sense and should be removed
 - should behave like the bold/italic font buttons which only showing on focus, which would probably solve the original bug

I'll make a patch for the latter.
Comment 5 Kai Uwe Broulik 2020-02-14 08:32:14 UTC
Yeah I think having the configure button hide when it doesn't have focus makes sense.
Why I didn't do it initially I think was so you don't have an awkward gap at the bottom when not in use but I also didn't want to resize the text field as the buttons came and go.
Comment 6 David Edmundson 2020-02-24 09:56:40 UTC
Git commit 9abedfec9d23106cfd8e66c3241155d31e29b896 by David Edmundson.
Committed on 24/02/2020 at 09:56.
Pushed by davidedmundson into branch 'master'.

[applets/notes] Only show configure button when focussed

Summary:
This makes the behaviour of the entire bottom panel consistent with how
the font buttons currently behave.

Test Plan:
Focussed widget, button appeared
Left focus, all buttons disappeared
Shrinking the widget hid the fonts buttons as expected

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27394

M  +3    -3    applets/notes/package/contents/ui/main.qml

https://commits.kde.org/kdeplasma-addons/9abedfec9d23106cfd8e66c3241155d31e29b896