Bug 417607 - Re-add manual port switching to the KCM
Summary: Re-add manual port switching to the KCM
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.18.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-14 03:14 UTC by David Polák
Modified: 2020-03-03 17:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
Ports missing with commit fb563192 (96.51 KB, image/png)
2020-02-14 03:14 UTC, David Polák
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Polák 2020-02-14 03:14:44 UTC
Created attachment 125998 [details]
Ports missing with commit fb563192

SUMMARY

The switching port functionality was removed from the applet. My headphone detection is broken in my laptop, currently can not use the applet to select to play sounds from headphones.

I've found the commit where the functionality was removed fb5631928121459597dc0015ba8c5b8b4be80c20


Workaround: use pavucontrol 


STEPS TO REPRODUCE
1. Checkout commit c88fedb1b8089bd0882e1409277505b87bb26b1a open the applet, observe being able to switch ports.
2. Checkout commit fb5631928121459597dc0015ba8c5b8b4be80c20 open the applet,
observe NOT being able to switch ports.

OBSERVED RESULT
No ports, can not select headphones

EXPECTED RESULT
Ports selection (it does not have to be in that exact place, but it's nowhere else)


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Kernel Version: 5.5.3-arch1-1
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 15.5 GiB of RAM

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-02-14 20:32:52 UTC
Yes, port switching is now automatic. But I guess that won't work if automatic port switching/headphone detection is broken on your machine. :/

What do you mean broken? Is this a hardware issue or a software issue?
Comment 2 David Polák 2020-02-15 01:14:21 UTC
(In reply to Nate Graham from comment #1)
> Yes, port switching is now automatic. But I guess that won't work if
> automatic port switching/headphone detection is broken on your machine. :/
> 
> What do you mean broken? Is this a hardware issue or a software issue?

It's a hardware issue, the detector is broken. Could it be added back, it doesn't have to be in the same location.
Comment 3 Nate Graham 2020-02-15 03:34:20 UTC
(In reply to David Polák from comment #2)
> It's a hardware issue, the detector is broken. Could it be added back, it
> doesn't have to be in the same location.
I'm tempted to say that using pavucontrol is an acceptable workaround in such an edge-case scenario, but perhaps we should re-add the port selector in the KCM, where we have more room. As you can see, we didn't consider this use case. Perhaps we should have.

Our design goal was to de-clutter the System Tray popup as much as possible as it was quite complicated and confusing for many people before. But maybe we can accept a bit more power in the KCM.

George, what do you think?
Comment 4 gvgeo 2020-02-15 13:14:42 UTC
https://phabricator.kde.org/D27420 BugFix
https://phabricator.kde.org/D27422 Restore KCM
Comment 5 gvgeo 2020-03-03 17:49:37 UTC
Git commit 606c6499750a1d776d73b052eab828dc5eedca07 by George Vogiatzis.
Committed on 03/03/2020 at 17:49.
Pushed by gvgeo into branch 'master'.

[KCM]Update Device item layout based on applet

Summary:
Remove device icon.
Remove separation line between devices and increase spacing.
Use radioboxes for default device selection.
Always allow port selection.
Fix mute tooltip.
Use small spacing instead of default.
Use plasma components 3 instead of qtquick controls 2.
Remove unused imports.
Related: bug 417447
FIXED-IN: 5.19.0

Doesn't depend, but needs D27420 to activate an unavailable port.

Test Plan:
Before:
Was not possible to select an unavailable port.
Combobox could drive the default button out of the layout.
After:
Combobox row appears for devices that have at least two ports.

{F8106609}

Reviewers: #plasma, drosca, ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27422

M  +66   -53   src/kcm/package/contents/ui/DeviceListItem.qml
M  +6    -3    src/kcm/package/contents/ui/Devices.qml
M  +2    -1    src/kcm/package/contents/ui/MuteButton.qml
M  +1    -0    src/kcm/package/contents/ui/StreamListItem.qml

https://commits.kde.org/plasma-pa/606c6499750a1d776d73b052eab828dc5eedca07