Bug 417597 - Parent loop for QLineSeries
Summary: Parent loop for QLineSeries
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kuserfeedback
Classification: Frameworks and Libraries
Component: Management and Analytics Console (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Volker Krause
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 20:19 UTC by David Edmundson
Modified: 2020-02-16 09:24 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/kuserfeedback/140c8ce688dfdf73ad485a2bb5559d45bbe08f3b
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2020-02-13 20:19:35 UTC 
When opening a graph:

20:17:50.358 QObjectPrivate::setParent_helper QObject 0x559a73321e40 (class: 'QtCharts::QLineSeries', object name: '') may have a loop in its parent-child chain; this is undefined behavior


This loop check only exists in debug Qt
Comment 1 David Edmundson 2020-02-13 20:25:23 UTC 
Line is this one:

         series->setParent(areaSeries); // otherwise series isn't deleted by removeAllSeries!


in both categoryaggregator and ratiosetaggregator

The relevant docs on ownership transfer in QAreaSeries are super confusing :/
Comment 2 Volker Krause 2020-02-13 20:31:38 UTC 
Is that Qt 5.14? Aleix also reported issues with the charts there I think, I am not seeing that with 5.13 though.
Comment 3 David Edmundson 2020-02-13 20:50:18 UTC 
It is
Comment 4 Volker Krause 2020-02-16 09:24:38 UTC 
Git commit 140c8ce688dfdf73ad485a2bb5559d45bbe08f3b by Volker Krause.
Committed on 16/02/2020 at 09:24.
Pushed by vkrause into branch 'master'.

Fix area charts with Qt 5.14

Summary:
Related: bug 416061

Reviewers: apol, davidedmundson

Reviewed By: apol, davidedmundson

Differential Revision: https://phabricator.kde.org/D27414

M  +3    -1    src/console/analytics/categoryaggregator.cpp
M  +3    -1    src/console/analytics/ratiosetaggregator.cpp

https://commits.kde.org/kuserfeedback/140c8ce688dfdf73ad485a2bb5559d45bbe08f3b