Bug 417583 - Request: icons for new Telegram Desktop SNI implemenation
Summary: Request: icons for new Telegram Desktop SNI implemenation
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
Depends on:
Reported: 2020-02-13 18:17 UTC by Christian (Fuchs)
Modified: 2020-05-01 07:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.68

Got a message (7.88 KB, image/png)
2020-02-13 18:21 UTC, David Redondo
Normal status (7.89 KB, image/png)
2020-02-13 18:21 UTC, David Redondo

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2020-02-13 18:17:02 UTC
In the most recent version of Telegram Desktop they switched from libappindicator to SNI and now support custom icons without hacks.

According to https://github.com/telegramdesktop/tdesktop/issues/7192
they are  telegram-{,attention-,mute-}panel.{svg,png}  

We do already provide a Telegram.svg it seems, it would be super nice if we provided the panel ones (telegram-panel.svg, telegram-attention-panel.svg, telegram-mute-panel.svg) as monochrome icons so that Telegram fits in nicely with the rest in the systray.
Comment 1 David Redondo 2020-02-13 18:20:09 UTC
I personally use these icons I think they fit perfectly in the system tray:
Comment 2 David Redondo 2020-02-13 18:21:00 UTC
Created attachment 125963 [details]
Got a message
Comment 3 Christian (Fuchs) 2020-02-13 18:21:36 UTC
The way these worked was a hack and will stop working in 1.19.3, so: as soon as you update your Telegram.
Comment 4 David Redondo 2020-02-13 18:21:42 UTC
Created attachment 125965 [details]
Normal status
Comment 5 Christian (Fuchs) 2020-02-13 18:24:52 UTC

after a bit of testing, if we want to use monochrome ones, we definitely need to provide all three variants 


otherwise it will use telegram-panel.svg in the default state, but fall back to attention the moment you get a message, so in this case it will be blue again. I'd prefer it to be distinguished from the non-message one (well, you will get an overlay with a counter badge, but assuming this can be disabled), but definitely not blue versus monochrome.
Comment 6 Nate Graham 2020-02-13 18:25:37 UTC
Still though, I wonder if the author would be willing to upstream them sans hack? Would one of you be interested in contacting him and inquiring about the possibility?
Comment 7 Christian (Fuchs) 2020-02-13 18:28:35 UTC
Personally I prefer just the default icon (the ball) in monochrome, but if David would prefer these and wants to contact the author: sure.
Comment 8 David Redondo 2020-02-13 18:30:17 UTC
Like this?
Comment 9 Nate Graham 2020-02-13 20:03:01 UTC
Personally I kind of prefer the un-circled paper airplane style icons.
Comment 10 Noah Davis 2020-03-05 03:40:11 UTC
Git commit 27740ce2613593ef656703934cc02ac6ba791f9d by Noah Davis, on behalf of Rocket Aaron.
Committed on 05/03/2020 at 03:40.
Pushed by ndavis into branch 'master'.

[breeze-icons] Add telegram-desktop tray icons

Recent version of telegram-desktop added support for using system icon theme for tray icon. This patch adds some icons following breeze style.

According to [[ https://github.com/telegramdesktop/tdesktop/issues/7192#issuecomment-586558835 | comments on GitHub ]] , pass environemnt variable `TDESKTOP_DISABLE_TRAY_COUNTER=1` to telegram-desktop also make it follows KDE color scheme.

Test Plan:
Before: {F8128166}


| breeze | breeze-dark |
| {F8128129} | {F8128123} |


| breeze | breeze-dark |
| {F8149461} | {F8149462} |

Reviewers: #vdg, Fuchs, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27617

A  +22   -0    icons-dark/apps/22/telegram-attention-panel.svg
A  +19   -0    icons-dark/apps/22/telegram-mute-panel.svg
A  +13   -0    icons-dark/apps/22/telegram-panel.svg
A  +22   -0    icons/apps/22/telegram-attention-panel.svg
A  +19   -0    icons/apps/22/telegram-mute-panel.svg
A  +13   -0    icons/apps/22/telegram-panel.svg

Comment 11 Michael D 2020-05-01 07:45:48 UTC
I know this is supposed to be fixed, and it was for me until a recent update, but after a few updates ago (on Manjaro testing) telegram has reverted back to the stock blue icon and not the symbolic breeze one. Not sure if this is due to a change in telegram-desktop or breeze icons.
Comment 12 David Redondo 2020-05-01 07:47:21 UTC
we had to revert because icon coloring was not working properly because of how telegram and plasma interact. Visible if one had a different plasma theme and global color scheme
Comment 13 Michael D 2020-05-01 07:50:39 UTC
That explains it--thanks!