Bug 417563 - Improve the title of window to configure application styles
Summary: Improve the title of window to configure application styles
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_style (show other bugs)
Version: 5.18.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 13:34 UTC by Patrick Silva
Modified: 2020-02-13 14:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.1
Sentry Crash Report:


Attachments
breeze style (49.89 KB, image/png)
2020-02-13 13:34 UTC, Patrick Silva
Details
QtCurve style (83.59 KB, image/png)
2020-02-13 13:34 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-02-13 13:34:11 UTC
Created attachment 125947 [details]
breeze style

SUMMARY
See the attached screenshots please.
Currently the titles of "Configure style..." windows are weird.
They should be "Configure <name of app style>".

STEPS TO REPRODUCE
1. open system settings > application style
2. hover over any app style and click on its "Configure style..." button
3. 

Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-13 13:34:32 UTC
Created attachment 125948 [details]
QtCurve style
Comment 2 Kai Uwe Broulik 2020-02-13 14:20:47 UTC
Git commit bc5c45e8aa9d0719c9bc09ff2db781c65ca54962 by Kai Uwe Broulik.
Committed on 13/02/2020 at 14:20.
Pushed by broulik into branch 'Plasma/5.18'.

[Styles KCM] Set style display name as window title

StyleConfigDialog doesn't actually load the config plugin, so it doesn't use the argument for loading but displaying.
Pass the display of the style to ensure a correct window title.
FIXED-IN: 5.18.1

Differential Revision: https://phabricator.kde.org/D27368

M  +2    -2    kcms/style/kcmstyle.cpp
M  +1    -1    kcms/style/kcmstyle.h
M  +1    -1    kcms/style/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/bc5c45e8aa9d0719c9bc09ff2db781c65ca54962