Bug 417514 - 2b78afd921e082b32edafbcdfa6074896e82dd99 regressed PC3 ToolButton sizing
Summary: 2b78afd921e082b32edafbcdfa6074896e82dd99 regressed PC3 ToolButton sizing
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI major
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-12 19:41 UTC by Nate Graham
Modified: 2020-02-20 18:21 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Yuuuuuge toolbuttons (149.78 KB, image/png)
2020-02-12 19:41 UTC, Nate Graham
Details
Expected appearance (151.89 KB, image/png)
2020-02-12 19:53 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-02-12 19:41:16 UTC
Created attachment 125912 [details]
Yuuuuuge toolbuttons

https://cgit.kde.org/plasma-framework.git/commit/?id=2b78afd921e082b32edafbcdfa6074896e82dd99 makes every PC3 toolbutton huge.

Check out the task manager tooltips for an example (screenshot attached).
Comment 1 Nate Graham 2020-02-12 19:53:12 UTC
Created attachment 125914 [details]
Expected appearance
Comment 2 Marco Martin 2020-02-14 10:40:27 UTC
It's not 2b78afd921e082b32edafbcdfa6074896e82dd99 reverting doesn't change anything for me.
It's the commit in plasma-desktop
5194d6183094ab654b341333e8e77b9e2c3554c8

which ports from plasmacomponents2 to 3.
I argue that the default size of the pc3 toolbutton is correct, as it's a standard toolbutton default size consistent with the desktop style
Comment 3 Kai Uwe Broulik 2020-02-14 10:41:51 UTC
Why do the buttons look so massive in Plasma then compared to Breeze widget style? It's also different from PlasmaComponents 2 which I think we wanted to be compatible with?
Comment 4 Marco Martin 2020-02-14 10:44:33 UTC
actually, in that commit you added icon.width: units.iconSizes.smallMedium
so i dupposed that button size was intended, icon.width: units.iconSizes.small makes it look as before
Comment 5 Marco Martin 2020-02-14 10:45:16 UTC
(In reply to Kai Uwe Broulik from comment #3)
> Why do the buttons look so massive in Plasma then compared to Breeze widget
> style? It's also different from PlasmaComponents 2 which I think we wanted
> to be compatible with?

i see that 2b78afd921e082b32edafbcdfa6074896e82dd99 indeed caused a regression, which was ignoring the icon.width/height hint. i reinstated it back
Comment 6 Marco Martin 2020-02-14 10:47:05 UTC
to me btw, with plasma components 2 the icon sizes there are 16x16 pixels, which is not a good default for a toolbutton, as the desktop one is 22x22 (modulo highdpi scaling)
Comment 7 Marco Martin 2020-02-14 11:02:25 UTC
see https://phabricator.kde.org/D27396
Comment 8 Marco Martin 2020-02-14 11:37:52 UTC
Git commit 3de1c2462eda58048170b90277eae983c86edfd7 by Marco Martin.
Committed on 14/02/2020 at 11:37.
Pushed by mart into branch 'master'.

support icon.width/height

Summary:
support the icon size hint of the control. Reinstate it in ToolButton
and add the support for the other controls

Test Plan:
possible to control buttons icon sizes
mediacontroller taskbar tooltip with icons set to small:
{F8103363}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27396

M  +6    -2    src/declarativeimports/plasmacomponents3/Button.qml
M  +6    -3    src/declarativeimports/plasmacomponents3/TabButton.qml
M  +6    -2    src/declarativeimports/plasmacomponents3/ToolButton.qml

https://commits.kde.org/plasma-framework/3de1c2462eda58048170b90277eae983c86edfd7
Comment 9 Nate Graham 2020-02-14 14:22:30 UTC
Seems fixed now, but JFYI now we need to fix the Pin button in the System Tray popup: https://phabricator.kde.org/D27260.
Comment 10 Nate Graham 2020-02-20 18:21:47 UTC
Marco fixed this recently.