Bug 417499 - Wayland session is called "Plasma (Wayland) (Wayland)" in SDDM kcm
Summary: Wayland session is called "Plasma (Wayland) (Wayland)" in SDDM kcm
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.18.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-12 15:37 UTC by Patrick Silva
Modified: 2020-02-15 10:52 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/sddm-kcm/c0fdf0039be47b5d890346d45bbb1d763d65379a
Version Fixed In:

Attachments
screenshot (73.93 KB, image/png)
2020-02-12 15:37 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-02-12 15:37:07 UTC 
Created attachment 125903 [details]
screenshot

STEPS TO REPRODUCE
1. open SDDM kcm
2. click on "Advanced" tab
3. check "Automatically log in" and open "with session" dropdown

OBSERVED RESULT
dropdown shows "Plasma (Wayland) (Wayland)" entry.
See the attached screenshot.

EXPECTED RESULT
"Plasma (Wayland)" entry instead

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Nate Graham 2020-02-12 22:29:31 UTC 
Is the session name the same from the chooser on the login screen?
Comment 2 Patrick Silva 2020-02-12 22:33:23 UTC 
on Arch, yes.
However, on Neon unstable login screen shows "Plasma (Wayland)" and SDDM kcm shows
"Plasma (Wayland) (Wayland)".
Comment 3 Nate Graham 2020-02-13 01:34:27 UTC 
What does `grep Name= /usr/share/wayland-sessions/*` print?
Comment 4 Patrick Silva 2020-02-13 01:58:51 UTC 
output on Arch:
/usr/share/wayland-sessions/gnome.desktop:Name=GNOME
/usr/share/wayland-sessions/plasmawayland.desktop:Name=Plasma (Wayland)
/usr/share/wayland-sessions/sway.desktop:Name=Sway
/usr/share/wayland-sessions/weston.desktop:Name=Weston

output on Neon unstable:
Name=Plasma (Wayland)
Comment 5 Nate Graham 2020-02-13 03:02:18 UTC 
Thanks. I'm drawing a blank on what's causing this, but I thought we'd fixed it...
Comment 6 Méven Car 2020-02-14 11:21:54 UTC 
Patch at https://phabricator.kde.org/D27397
Comment 7 David Edmundson 2020-02-14 13:03:31 UTC 
Git commit c0fdf0039be47b5d890346d45bbb1d763d65379a by David Edmundson.
Committed on 14/02/2020 at 13:03.
Pushed by davidedmundson into branch 'Plasma/5.18'.

Sync ("Wayland") appending to match SDDM

Summary:
For historical reasons some .desktop files in wayland-sessions suffix
their .desktop files, some expect the display manager to do it.

SDDM compares the suffix and only adds if needed. Our config UI should
match exactly.

The obvious comment is this only works in English, but for some reason
both SDDM and this code only read the Name entry in English anyway.

Test Plan: Opened KCM

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27358

M  +5    -2    src/sessionmodel.cpp

https://commits.kde.org/sddm-kcm/c0fdf0039be47b5d890346d45bbb1d763d65379a
Comment 8 Patrick Silva 2020-02-14 17:45:29 UTC 
David, I have just built 5.18 branch on my Arch, your patch fixes the kcm bug.
But the dropdown of login manager is still saying "Plasma (Wayland) (Wayland)".
Is this another issue?
Comment 9 David Edmundson 2020-02-14 17:50:14 UTC 
This only changes the kcm, sddm itself is changed in newest SDDM
Comment 10 Andreas Sturmlechner 2020-02-15 10:52:20 UTC 
The obvious answer there of course is there is no new sddm release yet and it is up to the distros to backport the related fix.