Bug 417437 - horizontal lines cross the scroll bar
Summary: horizontal lines cross the scroll bar
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_baloo (show other bugs)
Version: 5.18.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ongun Kanat
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-02-11 18:07 UTC by Patrick Silva
Modified: 2020-02-14 17:03 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.1


Attachments
screenshot (181.23 KB, image/png)
2020-02-11 18:07 UTC, Patrick Silva
Details
Networks KCM screenshot (130.00 KB, image/png)
2020-02-14 16:12 UTC, Ongun Kanat
Details
Networks KCM screenshot (117.34 KB, image/png)
2020-02-14 16:14 UTC, Ongun Kanat
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-02-11 18:07:54 UTC
Created attachment 125857 [details]
screenshot

STEPS TO REPRODUCE
1. have amount of ignored locations enough to activate the scroll bar of "File search" kcm
1. open system settings > search
2. 
3. 

OBSERVED RESULT
As we can see in the attached screenshot, horizontal lines cross the scroll bar

EXPECTED RESULT
nothing should cross the scroll bar

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Nate Graham 2020-02-12 22:11:29 UTC
*groan*

Can confirm with everything from git master.
Comment 2 David Edmundson 2020-02-13 18:21:40 UTC
better test

import QtQuick.Controls 2.11 as QQC2
import QtQuick.Dialogs 1.2 as QtDialogs
import org.kde.kirigami 2.4 as Kirigami
import QtQuick 2.1
import QtQuick.Layouts 1.1

QQC2.ScrollView {
    width: 1000
    height: 1000
    id: bgObject
    Component.onCompleted: bgObject.background.visible = true
    Layout.fillWidth: true
    Layout.fillHeight: true

    ListView {
        id: fileExcludeList
        anchors.fill: parent

        model: 200
        delegate: Kirigami.BasicListItem {
            label: "ASDF " + model.index
        }
    }
}
Comment 3 Arjen Hiemstra 2020-02-13 19:41:53 UTC
Git commit 83b920946c52c2f100a21e1e14af693f14f3e3a7 by Arjen Hiemstra.
Committed on 13/02/2020 at 19:41.
Pushed by ahiemstra into branch 'Plasma/5.18'.

Baloo KCM: Do not anchor fill ScrollView

Summary:
ScrollView will resize any single child flickabe to the right size.
However, this behaviour breaks if that child specifies anchors,
causing the child to ignore any padding specified in ScrollView.
Removing the anchoring fixes the scrollbar overlapping and also
fixes list items poking outside the scrollview border.
FIXED-IN: 5.18.1

Test Plan:
Before:

{F8101357}

After:

{F8101358}

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27379

M  +0    -1    kcms/baloo/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/83b920946c52c2f100a21e1e14af693f14f3e3a7
Comment 4 Ongun Kanat 2020-02-14 16:12:55 UTC
Created attachment 126020 [details]
Networks KCM screenshot

It seems like networks KCM also suffers from the same bug. Consider fixing the bug in Kirigami maybe?
Comment 5 Ongun Kanat 2020-02-14 16:14:33 UTC
Created attachment 126021 [details]
Networks KCM screenshot
Comment 6 Nate Graham 2020-02-14 16:42:29 UTC
Please open a new bug in "plasma-nm | KCM" to track that issue.
Comment 7 David Edmundson 2020-02-14 17:03:22 UTC
that network thing happens to be fixed already