Bug 417294 - Now Playing page's scrollview is broken
Summary: Now Playing page's scrollview is broken
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-02-08 03:52 UTC by Nate Graham
Modified: 2020-02-10 18:56 UTC (History)
0 users

See Also:
Latest Commit: https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=6995b4ae81a2f3ca3c24d2fa6d1560bfe0898737
Version Fixed/Implemented In: 5.68
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-02-08 03:52:19 UTC 
It doesn't scroll vertically anymore; long lyrics just get clipped off the bottom.

This is broken in master, but fine on the stable branch. Git bisect says the problem was introduced in https://cgit.kde.org/elisa.git/commit/?id=efe69043538e58cf5025b2a6f60416f9842e9474, which I can confirm.

Looking at the diff, I can't understand how this could have regressed the Now Playing view.
Comment 1 Nate Graham 2020-02-10 18:56:46 UTC 
This turned out to have been caused by a qqc2-desktop-style regression that was just fixed in https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=6995b4ae81a2f3ca3c24d2fa6d1560bfe0898737