Bug 417209 - selecting clips in timeline and going back and forth with mouse wheel doesn't work
Summary: selecting clips in timeline and going back and forth with mouse wheel doesn't...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: 19.12.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-06 00:14 UTC by CzAndrew
Modified: 2022-03-22 13:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:
fritzibaby: timeline_corruption+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description CzAndrew 2020-02-06 00:14:26 UTC
SUMMARY
When I'm selecting clips, going back and forth on the timeline with mouse wheel doesn't work. 
Usually when I have a long project with many clips, I zoom in, to start the selection, then I use the mouse wheel to go back/forth on the timeline to continue selecting clips. This feature doesn't work in 19.12.1. It did work in 18.12.2.
Of course, I could zoom back completely to see the complete project on the timeline all at once, but if I have many clips, then it is very hard to see where one ends and the other starts.

STEPS TO REPRODUCE
1. Open a project with many clips in the timeline.
2. Zoom in the timeline, press shift, and start the selection.
3. While pressing the shift and left mouse button, try to move the timeline by mousewheel. It does work in 18.12.2, but doesn't work in 19.12.1.

OBSERVED RESULT
19.12.1: the mouse wheel doesn't move the timeline during selection. When the clips are not being selected, then the timeline can be moved by the mouse wheel.

EXPECTED RESULT
During selection the mouse wheel moves the timeline back and forth, so selecting the clips can be continued.

SOFTWARE/OS VERSIONS
Windows: 19.12.1

ADDITIONAL INFORMATION
Workaround: In 19.12.1, there is a small few pixel tall space under the horizontal scrollbar of the timeline. If the mouse pointer is on that space, then the mouse wheel works during selection.
Comment 1 emohr 2020-03-08 16:05:50 UTC
Correct. You have to release shift before you can scroll with the mouse. Ones scrolled, hold shift and you can select further. 

Yes, when you with the mouse hoover over the not so good visible scroll bar, below the timeline, then you can scroll with holding shift. I don't know if this is a bug or a wish to change.
Comment 2 CzAndrew 2020-03-08 18:12:58 UTC
If I start selecting a clip, and release the shift, then I can scroll the timeline, but the start of the selection doesn't "stick" to the part where I started to select the clips. The selection box just stays at the place while the clips on the timeline moves behind it.
It was different in 18.12.2, and I think this would be the correct and expected behavior of selecting clips.
(If you want to, I'll make a video of it how selection worked in 18.12 vs in 19.12)
Comment 3 emohr 2020-03-08 18:45:50 UTC
Yes a small video would help. Please upload here.
Comment 4 CzAndrew 2020-03-08 20:26:32 UTC
Here is the video clip:
In v18.12 the start of the selection sticks to the actual position of the timeline, while in v19.12 the selection just floats on top of the timeline while the clips are moving behind it.

https://drive.google.com/open?id=14x9xeGUYx9GDV2Nf8EGc2QH0wbGOgfv-
Comment 5 CzAndrew 2020-03-08 20:27:18 UTC
And I forget: in 18.12 I don't have to release the shift to move the timeline.
Comment 6 CzAndrew 2020-03-08 20:32:42 UTC
The link in the previous message is not working, the full link contains the "-" at the end. Just copy-paste the link instead of clicking on it.

I try to paste it here again, maybe it works this way:
"https://drive.google.com/open?id=14x9xeGUYx9GDV2Nf8EGc2QH0wbGOgfv-"
Comment 7 Jean-Baptiste Mardelle 2020-03-09 07:52:30 UTC
Thanks for noticing this. In fact, we remapped Shift + mouse wheel to vertical scrolling, which explains why selecting while scrolling doesn't work anymore.

I agree that your use case is probably more useful so we should find a better way to handle this.

Currently we have:

Ctrl + click and drag: pan timeline
Wheel scroll in timeline headers: vertical scroll
Wheel scroll in timeine: horizontal scroll
Shift + Wheel scroll in timeine: vertical scroll
Wheel in ruler: seek

So we should probably drop Shift + Wheel scroll to restore previous behavior.
Should we simply drop vertical scroll in timeline ?
Comment 8 CzAndrew 2020-03-09 09:55:05 UTC
The problem is not with the key bindings, but that the beginning of the selection box doesn't stick to the current position of the timeline.

Watch the video I attached, and notice that in v18.12 the beginning of the selection "sticked" to the current position of the timeline, so as I scrolled the timeline, the selection box got bigger, so I selected the clips starting from the clip where I pressed shift+mouse button, then scrolled, and the selection ended where I released the mouse button.
In v19.12 the selection box just floats on top of the timeline, and the beginning of the selection doesn't move with the clips I started the selection.
Comment 9 Jean-Baptiste Mardelle 2020-03-09 12:37:15 UTC
Git commit bfec04aa6f75c7bd4c8a5f3ba960e98612627141 by Jean-Baptiste Mardelle.
Committed on 09/03/2020 at 12:37.
Pushed by mardelle into branch 'master'.

Fix timeline rubberband when scrolling.

M  +16   -6    src/timeline2/view/qml/timeline.qml

https://invent.kde.org/kde/kdenlive/commit/bfec04aa6f75c7bd4c8a5f3ba960e98612627141
Comment 10 CzAndrew 2020-03-10 13:55:47 UTC
I tested it with the newest nightly, but the bug is still there. Should I wait for the final kdenlive?

I downloaded kdenlive from here:
https://binary-factory.kde.org/job/Kdenlive_Nightly_mingw64/lastSuccessfulBuild/artifact/
Comment 11 Julius Künzel 2021-03-17 20:11:22 UTC
Can you please test with the latest version (20.12.3 at the moment, https://kdenlive.org/en/download/) and close this report if it is not relevant anymore?
Comment 12 CzAndrew 2021-03-17 21:48:56 UTC
I just tested it with 20.12.3.
The feature is still not working correctly:
I start the selection by holding shift and clicking, but when I use the mouse wheel during that, the timeline doesn't goes back or forth. If I move the cursor to the left or right side of the timeline, then the timeline scrolls slowly (as it should), but the mouse wheel doesn't move the timeline at all.
Comment 13 Jean-Baptiste Mardelle 2022-03-22 13:01:59 UTC
Git commit 70378af1e5fc3979daa725b5a8972b593653c014 by Jean-Baptiste Mardelle.
Committed on 22/03/2022 at 13:00.
Pushed by mardelle into branch 'release/22.04'.

Fix rubberband selection on scroll, and don't overlap track headers, fix move clip + mouse wheel.

M  +94   -45   src/timeline2/view/qml/timeline.qml

https://invent.kde.org/multimedia/kdenlive/commit/70378af1e5fc3979daa725b5a8972b593653c014